Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect checkbox field #3034

Closed
bhousel opened this issue Mar 14, 2016 · 12 comments
Closed

Multiselect checkbox field #3034

bhousel opened this issue Mar 14, 2016 · 12 comments
Assignees
Labels
field An issue with a field in the user interface

Comments

@bhousel
Copy link
Member

bhousel commented Mar 14, 2016

Some tags in OSM use this style of tagging where people can make up what they want in the key part of the tag. iD doesn't really support it. We can turn the most popular values into checkbox fields, but that takes up a lot of space in the sidebar and we will never be able to show all of the values that people care about:

recycling:cans = yes/no
recycling:clothes = yes/no
recycling:glass = yes/no
recycling:batteries = yes/no
recycling:paper = yes/no

Ideally we would have a field that

  • allows mappers to add/remove terms
  • turns those terms into labelled checkboxes
  • takes up little space
  • supports localization (this one is a stretch)

If we had this, it would unblock issues like:
#2873, #2872, #2827, #1987

@kepta want to take a shot at this?

@bhousel bhousel added the field An issue with a field in the user interface label Mar 14, 2016
@kepta
Copy link
Collaborator

kepta commented Mar 14, 2016

Sure, let me assign it to myself.

@kepta kepta self-assigned this Mar 14, 2016
@bhousel
Copy link
Member Author

bhousel commented Mar 16, 2016

How Wordpress handles this is 👌

multiselect_field

@d1g
Copy link

d1g commented Mar 16, 2016

https://github.com/selectize/selectize.js - jQuery-based

--plugins=remove_button

@kepta
Copy link
Collaborator

kepta commented Mar 19, 2016

I like the way Google has done Material chips, but I don't know whether that would blend well with iD's look and feel.

@kepta
Copy link
Collaborator

kepta commented Mar 30, 2016

This is what current implementation looks like.

screen shot 2016-03-30 at 10 42 28 pm 2

Any suggestions, @bhousel @jfirebaugh ?

@bhousel
Copy link
Member Author

bhousel commented Mar 30, 2016

That looks awesome!! Can't wait to merge this in. Design looks great to me, maybe @samanpwbb has suggestions?

What happens if the tag is recycling:paper=no - does it go into the "Accepts" bin. The field should probably quietly ignore everything except for an explicit yes value.

@bhousel
Copy link
Member Author

bhousel commented Mar 30, 2016

Oh I also just realized from the screenshot - it shouldn't offer to autocomplete paper or include in the dropdown list if that value is already selected.

@samanpwbb
Copy link
Member

This is awesome! Tiny nitpick:
screen shot 2016-03-30 at 1 52 00 pm

@kepta
Copy link
Collaborator

kepta commented Mar 30, 2016

@samanpwbb , wow, you have an eye for details. I will try to fix the alignment and add round corners.

@bhousel, I guess I need to update the combobox data and remove the used tokens.

@bhousel
Copy link
Member Author

bhousel commented Apr 30, 2016

merged! #3055 -> #3080

@TheAdventurer64
Copy link
Contributor

Similar to what @bhousel said, shouldn't mappers have a way to say something like payment:credit_cards=no?

@quincylvania
Copy link
Collaborator

@TheAdventurer64 See #7035.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field An issue with a field in the user interface
Projects
None yet
Development

No branches or pull requests

6 participants