Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle service multiselect #3535

Closed
bhousel opened this issue Oct 31, 2016 · 4 comments
Closed

Vehicle service multiselect #3535

bhousel opened this issue Oct 31, 2016 · 4 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@bhousel
Copy link
Member

bhousel commented Oct 31, 2016

Following out a side discussion from #3517..

Now that iD supports multicombo fields (see #3034, #3080), we have a really good way to allow people to tag multiple selections.

A few fields in OSM still prefer semicolon separated strings to represent multiple values.

For example: service=* (see shop=car_service),

service=dealer;repair;parts;tyres;electrical;glass

This one is especially bad because the service=* tag is overloaded for service highways.

(Compare to the service:bicycle:* namespace, which already exists and handles multiple values cleanly.)

So my question is, when we encounter tags like this, where

  1. the tag has obvious usefulness, and
  2. the existing tag is barely used if at all, and
  3. the wiki recommendation is clearly bad

Can we just disregard what the wiki says, and create a multiselect preset that expands to tags like service:vehicle:dealer service:vehicle:repair,service:vehicle:parts, etc.

Does anybody care about this vehicle service= tag enough that changing it would cause major problems?

@bhousel bhousel added waitfor-info Waiting for more info preset An issue with an OpenStreetMap preset or tag labels Oct 31, 2016
@bhousel bhousel changed the title Auto service multiselect Vehicle service multiselect Oct 31, 2016
@willemarcel
Copy link
Contributor

I agree with using the service:vehicle namespace tag for shop=car, shop=car_repair and shop=motorcycle.

@boothym
Copy link
Contributor

boothym commented Oct 31, 2016

Looks like service=* is only used in ~3800 of the ~100,000 shop=car_repair tags worldwide. So I agree with the change as it shouldn't cause major problems, and will make it easier to add services and bring that number up.

Though just wondering if the generic service:vehicle is correct or whether it should be service:car since it's car repair?

@bhousel
Copy link
Member Author

bhousel commented Oct 31, 2016

I was mostly thinking "vehicle" so it covers cars, trucks, motorcycles, etc.

@bhousel bhousel added waitfor-consensus Waiting for OpenStreetMap consensus and removed waitfor-info Waiting for more info labels Nov 1, 2016
@bhousel bhousel closed this as completed in 2d961b4 Mar 2, 2017
@bhousel
Copy link
Member Author

bhousel commented Mar 2, 2017

I did this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants