Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better marker styling for Mapillary panoramic images #3154

Closed
bhousel opened this issue Jun 8, 2016 · 1 comment
Closed

Better marker styling for Mapillary panoramic images #3154

bhousel opened this issue Jun 8, 2016 · 1 comment
Labels
streetlevel An issue with streetlevel photos usability An issue with ease-of-use or design

Comments

@bhousel
Copy link
Member

bhousel commented Jun 8, 2016

Panoramic images are cool! They render in the viewer with yellowish arrows and you can drag the viewer around 360 degrees:

mapillary-viewer-pano

But we don't handle them correctly. I discovered that when we call the Mapillary API, we get the same key multiple times with different camera angles:

> feature.properties.key
"vdjJHj_NLRqcYa08vElpZQ"
> feature.properties.ca
187.626653150049
//... some time later...
> feature.properties.key
"vdjJHj_NLRqcYa08vElpZQ"
> feature.properties.ca
203.359039340867

We are expecting this key to be normal unique key, so d3 will only show one of them as a normal marker. We should instead detect this condition in the loaded callback, set a flag that it is a panoramic image, and style the panoramic markers differently, not using ca (camera angle).

@bhousel bhousel added the design label Jul 18, 2016
@bhousel bhousel added usability An issue with ease-of-use or design and removed design labels Nov 1, 2016
@bhousel bhousel added streetlevel An issue with streetlevel photos and removed new-feature A new feature for iD labels Oct 25, 2017
@bhousel
Copy link
Member Author

bhousel commented Nov 7, 2017

The latest Mapillary API returns a pano flag if the image is panoramic, so I'm using this to render the viewfield as a circle:

screenshot 2017-11-07 01 02 45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
streetlevel An issue with streetlevel photos usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

1 participant