Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some more tags to your tag database #3439

Closed
dieterdreist opened this issue Sep 19, 2016 · 9 comments
Closed

add some more tags to your tag database #3439

dieterdreist opened this issue Sep 19, 2016 · 9 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@dieterdreist
Copy link

I suggest adding these tags to your tag database:
KEYS:

  • ref:vatin
  • service_times
  • source:maxspeed
  • tomb
  • historic:civilization
  • start_date
  • alt_name
  • old_name
  • oven

VALUES:

  • historic=road / roman_road
@bhousel
Copy link
Member

bhousel commented Sep 19, 2016

Hey @dieterdreist, thanks for the suggestions.. iD doesn't really have a tag database. OSM tags can be edited in the "All Tags" section of the editor, and iD will perform lookups using the taginfo service to suggest common keys and values.

Most users of iD interact with presets, which are common features that have the tags already set up for them. The presets have fields, which are additional optional tags that appear in the sidebar.

If you think there are additional presets or fields that iD should support, could you revise this ticket? It's also helpful to link to taginfo and the osm wiki, so that the iD developers can understand better what the tags are.

@bhousel bhousel added the preset An issue with an OpenStreetMap preset or tag label Sep 19, 2016
@dieterdreist
Copy link
Author

I am not sure if I understand you correctly, because I have noticed that some tags are autocompleted and others aren't, and this is likely not based on usage alone, maybe there is kind of a blacklist? I am sure there is some human judgement involved, and I agree it is necessary because of inports distorting usage numbers. I am particularly interested in getting the ref:vatin tag supported (vat identification number of a business) and the source:maxspeed (formalized way of storing the reason for a maxspeed, like sign (explicit), or zones for implicit limits), the latter being used very frequently (almost a million usage). This iD tag list is used also in other editors like GoMap!! for iOS.

@dieterdreist
Copy link
Author

What is your threshold for tag usage in order to consider a tag established/in use? Is it different for keys and values, and does it matter whether a tag is documented?

@dieterdreist
Copy link
Author

As for your suggestion to add tags to the presets: any "historic" preset should likely have an historic:civilization field, at least those regarding old stuff (unlike memorials and monuments which often are recent but connected to history).
Any place of worship should offer a service_times field
Any shop and craft and maybe office and some amenities (e.g. fast food, pub, restaurant, cafe, bar) should offer a ref:vatin field
Any feature could have a start_date field
Any highway for vehicles a maxspeed and source:maxspeed field
tomb could be a new preset or extension of historic=tomb
oven=wood_fired/electric could be an extension for cuisine=pizza and shop=bakery

@tbertels
Copy link

See also #1554

@dieterdreist
Copy link
Author

there is a problem with ref:vatin, it has 7700 uses currently but doesn't get autocompleted. Is it possible iD doesn't do autocompletion for ref-subtags in general? The vatin stands for VAT identification numbers, and (unlike many other ref subtags) has not been introduced via imports. The tag is also documented in the wiki on a key-page

@bhousel
Copy link
Member

bhousel commented Feb 26, 2017

there is a problem with ref:vatin, it has 7700 uses currently but doesn't get autocompleted. Is it possible iD doesn't do autocompletion for ref-subtags in general?

iD does autocomplete this tag, but you need to type up to ref:v first:
screenshot 2017-02-26 07 37 24

7700 uses just isn't all that many compared to the other tags that match ref:

@bhousel
Copy link
Member

bhousel commented Mar 2, 2017

I added a bunch of these..

  • alt names are covered by support for other name tags #1554
  • ref:vatin - Not sure how I would explain this to most users, so I didn't add it
  • service_times - added 23f9431
  • source:maxspeed - not added for now, not sure how to explain it, also highways are already pretty cluttered with fields
  • tomb - added 0c1194b
  • historic:civilization - added 4d64028
  • start_date - added ec0e9c5
  • oven - really limited use so didn't add it yet. Also we don't have a special preset for pizza places.

@bhousel bhousel closed this as completed Mar 2, 2017
@dieterdreist
Copy link
Author

dieterdreist commented Mar 2, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants