Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RTL in the walkthrough #3925

Closed
3 tasks done
bhousel opened this issue Mar 23, 2017 · 1 comment
Closed
3 tasks done

Improve RTL in the walkthrough #3925

bhousel opened this issue Mar 23, 2017 · 1 comment
Labels
walkthrough-help An issue with the walkthrough or help pane

Comments

@bhousel
Copy link
Member

bhousel commented Mar 23, 2017 •
edited
Loading

A few things going on here:

  • Tooltip placement math ignores RTL
  • The navigation buttons should support RTL (probably going to switch these to display:flex too)
  • curtain, curtain-tooltip, and intro-nav-wrap should all be under #id-container, not body, in order to pick up the dir=rtl attribute
@bhousel bhousel added the walkthrough-help An issue with the walkthrough or help pane label Mar 23, 2017
bhousel added a commit that referenced this issue Mar 24, 2017
@bhousel
Attach intro to id-container, not document.body
7432db7 
(re: #3925)
bhousel added a commit that referenced this issue Mar 25, 2017
@bhousel
Improve walkthrough tooltip placement, fix for RTL too
6cc524a 
(closes #3925)
@bhousel bhousel mentioned this issue Mar 25, 2017
Merged
11 tasks
@bhousel bhousel added the wip Work in progress label Mar 26, 2017
@bhousel
Copy link
Member Author

bhousel commented Mar 31, 2017 •
edited
Loading

curtain, curtain-tooltip, and intro-nav-wrap

  • also all comboboxes created by d3.combobox.js should be under #id-container not body

bhousel added a commit that referenced this issue Mar 31, 2017
@bhousel
Allow combobox to nest under id-container instead of body
f2f21a0 
(re: #3925 (comment))
bhousel added a commit that referenced this issue Mar 31, 2017
@bhousel
Add combobox menus to id-container instead of document.body
5f44c9a 
(re: #3925 (comment))
@bhousel bhousel removed the wip Work in progress label Apr 4, 2017
@bhousel bhousel closed this as completed Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
walkthrough-help An issue with the walkthrough or help pane
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhousel