Update to Mapillary API v3 and add new traffic signs #4050
Conversation
|
@bhousel Can you review this PR and check if it can be merged? API v2 will be turned off in the near future and we want to switch everyone to v3. |
|
7 Haz 2017 15:11 tarihinde Nikola Pleša <notifications@github.com> yazdı:
@bhousel<https://github.com/bhousel> Can you review this PR and check if it can be merged? API v2 will be turned off in the near future and we wan’t to switch everyone to v3.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#4050 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AXtAgr9awy1HZSfyuYU_m1cSCAwHNKPrks5sBpNYgaJpZM4Ndm3w>.
|
Sounds good @nickplesha, I'll try to get it merged today |
| var position = mapillarySignDefs[d.value]; | ||
| if (!position) return '<div></div>'; | ||
| var iconStyle = [ | ||
| 'background-image:url(img/traffic-signs/traffic-signs.png)', |
There was a problem hiding this comment.
I think I need to run this through context.asset() because once this is on the Rails site, the asset pipeline may rewrite the URL.
| if (region === 'de') region = 'eu'; | ||
| mapillarySignDefs[region] = data; | ||
| }); | ||
| d3.json(context.asset('img/traffic-signs/traffic-signs.json'), function(err, data) { |
|
Thanks for this, it looks really good!
|
|
Hello. https://www.celuaprikojums.lv/wp-content/uploads/2018/10/541.jpg |
Hello, this PR updates the Mapillary service to use the new API (v3) and adds support for new traffic signs.
Changes:
Reasons for these changes:
Let me know if you have any questions or need any help to improve the Mapillary integration.