Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Mapillary signs to use SVG icons instead of foreignobject #4145

Closed
bhousel opened this issue Jul 11, 2017 · 3 comments
Closed

Switch Mapillary signs to use SVG icons instead of foreignobject #4145

bhousel opened this issue Jul 11, 2017 · 3 comments
Labels
streetlevel An issue with streetlevel photos usability An issue with ease-of-use or design

Comments

@bhousel
Copy link
Member

bhousel commented Jul 11, 2017

Sign detection icons on the map are appearing a little blurry. I think they are being scaled now instead of being displayed at their native resolution. This probably happened in #4050 when switching from traffico to the spritesheet. We just have to determine the correct dimensions and change code in a few places to make them sharp again.

screenshot 2017-07-11 11 35 28
@bhousel bhousel added usability An issue with ease-of-use or design good first issue Best for first-time contributors. No experience necessary! labels Jul 11, 2017
bhousel added a commit that referenced this issue Jul 14, 2017
@bhousel
Adjust street sign image dimensions to try to make them less blurry
e71381e 
(still kinda blurry but closes #4145 anyway)
@bhousel
Copy link
Member Author

bhousel commented Jul 14, 2017

done in #4148

@bhousel bhousel closed this as completed Jul 14, 2017
@bhousel bhousel removed the good first issue Best for first-time contributors. No experience necessary! label Aug 11, 2017
@bhousel
Copy link
Member Author

bhousel commented Aug 11, 2017

Turns out that the svg source files themselves are in a different source repository:
https://github.com/mapillary/mapillary_sprite_source

We can just use these instead of the generated spritesheet. This gives us:

  • sharp icons at any resolution
  • can stop using <foreignObjects> and just use our svgIcon class 💥
  • support for all browsers now

@bhousel bhousel reopened this Aug 11, 2017
@bhousel bhousel changed the title Mapillary street signs blurry Switch Mapillary signs to use SVG icons instead of foreignobject Oct 25, 2017
@bhousel bhousel added streetlevel An issue with streetlevel photos and removed new-feature A new feature for iD labels Oct 25, 2017
@bhousel bhousel mentioned this issue Nov 29, 2017
Merged
@bhousel bhousel mentioned this issue Mar 16, 2018
Open
bhousel added a commit that referenced this issue Jun 7, 2018
@bhousel
Begin replacing mapillary signs html with svg spritesheet
b7997d3 
(re: #4145)
@bhousel bhousel closed this as completed in e149c6b Jun 7, 2018
@bhousel
Copy link
Member Author

bhousel commented Jun 7, 2018

Switched the icons to svg! They look so much better, and there are many more of them too.

screenshot 2018-06-07 01 14 46

@bhousel bhousel mentioned this issue Jun 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
streetlevel An issue with streetlevel photos usability An issue with ease-of-use or design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhousel