Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds mapillary detections #4148

Merged
merged 8 commits into from
Jul 14, 2017
Merged

Adds mapillary detections #4148

merged 8 commits into from
Jul 14, 2017

Conversation

kepta
Copy link
Collaborator

@kepta kepta commented Jul 12, 2017 •
edited
Loading

@kepta kepta requested a review from bhousel July 12, 2017 10:54
bhousel
bhousel approved these changes Jul 12, 2017
View reviewed changes
Copy link
Member

@bhousel bhousel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kepta looks pretty good! I added some guard code around tagComponent and mapillaryViewer - this fixes the failing tests. I'm going to tweak the styling of the bounding boxes a bit and merge maybe tonight.

@bhousel
Copy link
Member

bhousel commented Jul 12, 2017

Screenshot for anyone who is wondering what this PR is - to highlight the detected objects in the images.

screenshot 2017-07-12 17 42 59

@bhousel bhousel mentioned this pull request Jul 14, 2017
Closed
@bhousel
Copy link
Member

bhousel commented Jul 14, 2017

I added a few things..

  • results from the /detection api calls are cached now
  • make it so we can show many detections per image
  • style the detections for better visibility
  • cleanup the names

This is 🔥 now! Thanks @kepta for getting this started!

detections

@bhousel bhousel merged commit 30355d8 into master Jul 14, 2017
@bhousel bhousel mentioned this pull request Jul 24, 2017
Merged
@bhousel bhousel deleted the detections branch September 7, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhousel bhousel bhousel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight detected objects in Mapillary images
2 participants
@kepta @bhousel