Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'All tags' collapses every time a tag is changed or added #4159

Closed
ghost opened this issue Jul 17, 2017 · 8 comments
Closed

'All tags' collapses every time a tag is changed or added #4159

ghost opened this issue Jul 17, 2017 · 8 comments
Labels
bug A bug - let's fix this! bug-browser-specific A bug that only appears in certain browsers

Comments

@ghost
Copy link

ghost commented Jul 17, 2017

No description provided.

@ghost ghost changed the title "All tags" collapses every time a tag is changed or added [EOM] 'All tags' collapses every time a tag is changed or added [EOM] Jul 17, 2017
@bhousel
Copy link
Member

bhousel commented Jul 17, 2017

I haven't seen anything like what you are describing. What browser are you using?

Can you use LICEcap or similar to record a screencast of what you see?

@bhousel bhousel added the waitfor-info Waiting for more info label Jul 17, 2017
@ghost
Copy link
Author

ghost commented Jul 18, 2017

Hi! Thanks for replying. I'm using Safari on macOS:

osm_id_editor_problem

I've just downloaded Firefox: the problem doesn't occur with it.

@bhousel
Copy link
Member

bhousel commented Jul 18, 2017

Thanks for the update, that definitely looks like a bug!

@bhousel bhousel added bug A bug - let's fix this! and removed waitfor-info Waiting for more info labels Jul 18, 2017
@bhousel bhousel changed the title 'All tags' collapses every time a tag is changed or added [EOM] 'All tags' collapses every time a tag is changed or added Jul 22, 2017
@bhousel bhousel added the bug-browser-specific A bug that only appears in certain browsers label Jul 22, 2017
@bhousel
Copy link
Member

bhousel commented Jul 22, 2017

BTW, which version of Safari is this? I am testing with Version 10.1.1 (12603.2.4) - and it doesn't do quite what your screenshot shows, but it does oddly flash the url bar when tabbing off the value field.

@bhousel
Copy link
Member

bhousel commented Jul 22, 2017

@SelfishSeahorse Just a hunch, does clicking this button in Safari's Advanced Preferences screen fix the problem?

screenshot 2017-07-22 11 44 54

I've been playing with tabbing in Safari, and it definitely doesn't do what other browsers do when it reaches the end of the All Tags section.. Instead it tries to focus the address bar, but we steal that focus back a split second later when the new empty tag row is added.

Safari also tries to send the user to the address bar when tabbing through the "All Fields" (if "All Tags" section is hidden). Or it tries to send the user to the address bar when tabbing past the end of "All Relations" section. Basically, Safari just does this after the user tabs away from whatever Safari decides is last tab-able thing in the sidebar.

I can possibly add a keyboard trap as a workaround. This would be like a hidden fake input field that appears in the DOM after the other sidebar content and doesn't allow the user to tab out of it, thus preventing them from accidentally focusing the address bar.

related: https://stackoverflow.com/a/1914496/7620

@ghost
Copy link
Author

ghost commented Jul 23, 2017

BTW, which version of Safari is this? I am testing with Version 10.1.1 (12603.2.4)...

I'm using version 10.1.1 (12603.2.4), too (on MacOS Sierra 10.12.5). However, I've just found out that the problem only occurs in Private Browsing mode. So I won't use that again.

By the way, in Private Browsing mode, the 'All tags' section collapses not only when pressing the tab key, but also when moving from one field to the next with the mouse.

@bhousel
Copy link
Member

bhousel commented Jul 23, 2017

I'm using version 10.1.1 (12603.2.4), too (on MacOS Sierra 10.12.5). However, I've just found out that the problem only occurs in Private Browsing mode. So I won't use that again.

By the way, in Private Browsing mode, the 'All tags' section collapses not only when pressing the tab key, but also when moving from one field to the next with the mouse.

Oh this makes a lot of sense, thanks! You can continue to use Private Browsing mode - I'll fix the issue that's causing the sidebar sections to collapse, and release a new iD in the next day or so.

bhousel added a commit that referenced this issue Jul 24, 2017
In other words, don't rely on context.storage() working
(re: #4159)
@ghost
Copy link
Author

ghost commented Jul 25, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! bug-browser-specific A bug that only appears in certain browsers
Projects
None yet
Development

No branches or pull requests

1 participant