-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination fields for link features #4178
Comments
I agree this would be a valuable addition.. @1ec5 can you take the lead on adding these fields to all the link presets?
I'm less convinced that this is a good idea - often the link road doesn't really connect to the I might be confused about proper tagging though. A good example is the destination sign here. It says "To I-78", but I-78 is about a mile away. |
I agree that there would be plenty of false positives. If we implemented it as a dropdown suggestion, would that mitigate the problem? The problem this suggestion attempts to address is that, in the U.S. and a few other countries, the way ref prefixes aren't especially discoverable from looking at street-level photography alone. However, on second thought, maybe the better approach is to improve Mapillary's sign detection to the point where we could rely on its detection of route shields. 🤔 |
This is where you'd use the |
Yes that is probably best for now. It could work similarly to how we have dropdowns for some of the Address fields, which can suggest things like Street, City, Zip from nearby features.
I guess the real question is, how bad is it for somebody to add If destination tagging is really complex, we might need to build a special field for it (like we have for turn restrictions) - which is fine, but a much bigger lift and pushes this back a few months. I'm reading here: https://wiki.openstreetmap.org/wiki/Exit_Info - it does seem kind of complicated. |
OSRM doesn’t currently recognize More to your point, these destination tags affect guidance instructions attached to a route but not the route itself. Some of the differences between the tags are quite subtle, like For data consumers, issues with freeway ramp guidance can really affect usability, almost as much as connectivity issues. But given the rabbit hole we could go down – a graphical guidance sign layout tool, anyone? – I think we should start small with a few ordinary fields for common tags. At least that would discourage misuse of |
These fields make even more sense to add now that we have #5582. Before seeing this issue, I added a basic text field for |
You don't want |
In 6adc174 I added fields for all four properties to all of the highway I think this system actually works pretty well. Later on someone could make custom fields for the @1ec5 I'd love to hear your feedback! I'm also wondering if this issue should be closed or renamed or not. |
Cool! I tried this out around my favorite spaghetti junction. I like it! One thing that I think we might need to address is that the destination values are supposed to be ordered in the semicolon delimited list - from the top of the sign to the bottom. I'm not sure whether our I'd like to get @1ec5's thoughts whether this matters. If this is something that would cause problems, I'm pretty ok with them being plain |
@bhousel It looks like the |
Thanks @quincylvania, I’m really digging the more flexible optional field mechanism. There are more complicated scenarios requiring additional tags like
The order is meaningful in Dragging-and-dropping the chips would be ideal but not essential. If mappers don’t figure out that the order matters, maybe we could try applying Is there a way to hide the dropdown arrow on the I brought up Great work @quincylvania! |
@1ec5 Thanks for the detailed response!
I like both of these ideas a lot! The dropdown arrow is certainly deceiving when no menu pops up. I'll work on these items and leave the fields as
I agree it would be cool to generalize that field one day if anyone is looking for more work 😄. I'm closing this issue since I think the four new fields are sufficient for now. Feel free to open new issues for any lingering tasks. |
…o mimic the layout of highway signs (re: #4178) The input and combobox caret elements in the multicombo field value list are now wrapped in a li element for consistency
… Trunk Link presets (re: #4178) Fields with a prerequisiteTag property no longer count against the fields count buildtime check
Freeway ramp tagging would be much more efficient if iD would include destination fields in its link presets. These fields would also steer mappers away from naming freeway ramps with descriptive names like “Ramp to Story Rd. East” just to get a navigation application to announce a ramp correctly.
The Motorway Link and Trunk Link presets (and maybe the other link presets?) would have the following additional fields:
destination
) – textdestination:ref
) – textdestination:symbol
) – combo boxjunction:ref
) – textSince it’s possible for a link way to be two-way, it may be preferable to split these tags into
:forward
and:backward
fields, similar to how the Cycleway field is split into:left
and:right
fields.As a stretch goal, it would be awesome if the Destination References field could suggest refs based on the
ref
tag on the connecting non-link way. (Although for the U.S., cardinal directions would have to be determined by looking at route relations.) The Junction Reference field could also suggest the connecting motorway junction’sref
tag.#1878 suggests adding a similar field to the Motorway Junction preset, based on the
exit_to
tag, but that tag is more or less moribund at this point.The text was updated successfully, but these errors were encountered: