-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Street name labeling obscuring node features #4271
Comments
I agree, the label placement should avoid tagged nodes.. |
Relevant code is here for anyone who wants to work on this.. |
Hi @simonpoole, can you clarify what is being obscured by the street name? Thanks! |
Hi @Nitiquita this code is a bit advanced for a get started issue, but I'll try to break down what's happening. This code in Lines 296 to 302 in 7e98d7f
Inside Lines 275 to 278 in 7e98d7f
One of the first things the Lines 293 to 316 in 7e98d7f
☝️ My thought is that inside the if (entity.hasInterestingTags()) {
var coord = projection(entity.loc);
var pad = 5; // pixels of padding around the vertex
var bbox = {
minX: coord[0] - pad,
minY: coord[1] - pad,
maxX: coord[0] + pad,
maxY: coord[1] + pad
};
rdrawn.insert(bbox);
} To get more insight into what the label placement code is doing, you can open a developer console and type |
I did some work on this today and it's a lot better.. 006ee69 Adds label avoidance boxes for all points This work will land with #4602, which changes a bit how vertices are rendered. |
done in #4602 |
See http://www.openstreetmap.org/edit?editor=id#map=21/47.40755/8.54858 there is actually a pedestrian crossing already there, but the node can't be seen (a slightly more prominent icon would address the issue too).
The text was updated successfully, but these errors were encountered: