Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues with conflict resolution screen #4351

Closed
2 of 3 tasks
bhousel opened this issue Sep 15, 2017 · 3 comments
Closed
2 of 3 tasks

Minor issues with conflict resolution screen #4351

bhousel opened this issue Sep 15, 2017 · 3 comments
Labels
bug A bug - let's fix this!

Comments

@bhousel
Copy link
Member

bhousel commented Sep 15, 2017

  • esc should not cancel save mode and return to browse mode (allowing users to edit during conflict resolution) - rather, esc should be the same as hitting the conflict resolution cancel button.
  • Don't show "all conflicts resolved" message and do not unlock save button, before the user has actually clicked anything (it's also possible that "use theirs" was actually selected by default but somehow the radio button did not update):
  • Check if wrong username is being reported when there is a conflict with editing child nodes but displaying the username of the parent way. see Minor issues with conflict resolution screen #4351 (comment)

screenshot 2017-09-14 21 42 33

@bhousel bhousel added the bug A bug - let's fix this! label Sep 15, 2017
@jjiglesiasg
Copy link

By the way and happen to me often. How we can have a conflict resolution with ourselves?

@bhousel
Copy link
Member Author

bhousel commented Oct 24, 2017

By the way and happen to me often. How we can have a conflict resolution with ourselves?

I sometimes trigger one intentionally to test, but I do this by opening iD in two separate browser tabs.

I think I have seen occasionally where I can generate a conflict with another user by moving some nodes of a way, however the my own name is displayed because they I touched the way. I will check this and see if it's the cause and if we can improve the message.

@bhousel bhousel added the wip Work in progress label Jan 5, 2018
bhousel added a commit that referenced this issue Jan 8, 2018
This fixes one of the issues in #4351 where the radio button was not
selected. This was likely introduced during the upgrade to d3 v4, now
that enter selections do not automatically flow into update anymore.
(the fix is to add a `merge` to ensure that the `selection.each` actually
has some things to iterate over)
@bhousel
Copy link
Member Author

bhousel commented Jan 8, 2018

I will check this and see if it's the cause and if we can improve the message.

Just an update - I couldn't spot anything obvious in the code that would cause the wrong username to display, but if this happens again, we can reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants