-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor issues with conflict resolution screen #4351
Comments
By the way and happen to me often. How we can have a conflict resolution with ourselves? |
I sometimes trigger one intentionally to test, but I do this by opening iD in two separate browser tabs. I think I have seen occasionally where I can generate a conflict with another user by moving some nodes of a way, however the my own name is displayed because they I touched the way. I will check this and see if it's the cause and if we can improve the message. |
This fixes one of the issues in #4351 where the radio button was not selected. This was likely introduced during the upgrade to d3 v4, now that enter selections do not automatically flow into update anymore. (the fix is to add a `merge` to ensure that the `selection.each` actually has some things to iterate over)
Just an update - I couldn't spot anything obvious in the code that would cause the wrong username to display, but if this happens again, we can reopen this issue. |
The text was updated successfully, but these errors were encountered: