Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for kerb barrier preset #4715

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Conversation

jmandel1027
Copy link
Contributor

Hi there,

I saw issue #4702 and this looked like a good place to get acquainted with the codebase and start contributing. I went ahead and wrote kerb.json file as well, I was a little unsure of which icon to use so I went with 'wheelchair' from the maki icon set.

It might be a good idea to create icons to differentiate between wheelchair friendly and unfriendly barriers. Happy to draft up a proper issue/proposal for that as well n_n

Hope this helps!
-Jason

Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, only a few minor changes..

"access"
],
"geometry": [
"point",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this preset, change "point" to "vertex".. (Points are standalone nodes, and vertices are nodes that exist along a parent way)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good i'll make these tweaks 👍

{
"icon": "wheelchair",
"fields": [
"access"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "access" field makes sense here.
You could add "kerb" and "tactile_paving" in its place, since we already have fields set up for those tags..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing!

@bhousel bhousel merged commit 67c77d3 into openstreetmap:master Jan 23, 2018
@bhousel
Copy link
Member

bhousel commented Jan 23, 2018

Thanks, looks good!

@jmandel1027
Copy link
Contributor Author

Thanks @bhousel!

Happy to help out, I'll keep an eye out for other issues to take on. Are there any projects or areas of interest you guys are particularly looking for help with?

@bhousel
Copy link
Member

bhousel commented Jan 23, 2018

Great @jay-manday - You can always dig into anything tagged with "bug" or "help wanted"..

Not sure whether you are in college, but if so you might be eligible for Google Summer of Code. Later today I will add some more long term project ideas to GSoC ideas page here: https://wiki.openstreetmap.org/wiki/Google_Summer_of_Code/2018/Project_Ideas

@jmandel1027
Copy link
Contributor Author

jmandel1027 commented Jan 23, 2018

Sounds good, I'll keep a look out!

Definitely, I see some really interesting projects there. Yup! I'm a senior studying comp sci and studio art at a small but good arts college. I'll keep my eye for projects there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants