Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for kerb barrier preset #4715

Merged
merged 2 commits into from
Jan 23, 2018
Merged

added support for kerb barrier preset #4715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03a068e
added support for kerb barrier preset
jmandel1027 Jan 20, 2018
2b862a1
made desired tweaks to kerb.json
jmandel1027 Jan 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions data/presets/categories/barrier.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"barrier/ditch",
"barrier/gate",
"barrier/hedge",
"barrier/kerb",
"barrier"
]
}
14 changes: 14 additions & 0 deletions data/presets/presets/barrier/kerb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"icon": "wheelchair",
"fields": [
"access"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "access" field makes sense here.
You could add "kerb" and "tactile_paving" in its place, since we already have fields set up for those tags..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing!

],
"geometry": [
"point",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this preset, change "point" to "vertex".. (Points are standalone nodes, and vertices are nodes that exist along a parent way)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good i'll make these tweaks 👍

"vertex"
],
"tags": {
"barrier": "kerb"
},
"name": "Kerb"
}