Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharmacy preset should have dispensing field #4763

Closed
eehpcm opened this issue Feb 1, 2018 · 3 comments
Closed

Pharmacy preset should have dispensing field #4763

eehpcm opened this issue Feb 1, 2018 · 3 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag

Comments

@eehpcm
Copy link

eehpcm commented Feb 1, 2018

Most pharmacies will be dispensing=yes, although OTC-only pharmacies will be dispensing=no. This can be added by knowledgeable users under "All tags" but it would be helpful to newbies (and make life a tad easier for knowledgeable users) if this were prompted under "All fields." More useful than offering "Drive-Through" because I've never seen a drive-through pharmacy here in the UK but I've yet to see a pharmacy that wasn't also dispensing=yes.

@bhousel
Copy link
Member

bhousel commented Feb 1, 2018

I've yet to see a pharmacy that wasn't also dispensing=yes.

If that's the case, then why tag it at all?

@eehpcm
Copy link
Author

eehpcm commented Feb 1, 2018

Five reasons.

  1. Although I've never seen a pharmacy in the UK that wasn't dispensing, I haven't seen all UK pharmacies. There may be some that aren't.

  2. The situation may be very different in other countries. This is implied by the fact that the wiki (down, as I write this) has a page for the dispensing tag which says (google cache is helpful here) for dispensing=no "A pharmacy with a pharmacist that does not fill prescriptions, but does sell pharmacist-only drugs (e.g., pseudoephedrine in the US)."

  3. There is no indication in the wiki what value is assumed for this tag if it is not present. Any of "yes," "no," or "unknown" might be assumed. And might be assumed differently by different renderers.

  4. I doubt there are many drive-through pharmacies in the UK. Let's remove that too, irrespective of how many there may be in the US. :)

  5. I have a vague memory from the last pharmacy I mapped that the renderer didn't show a pharmacy icon unless dispensing=yes was present. This isn't tagging for the renderer, that pharmacy was a dispensing pharmacy. But I wouldn't have thought to add that tag until I started investigating why the icon wasn't showing.

But if you don't want to, you don't want to.

@bhousel
Copy link
Member

bhousel commented Feb 1, 2018

I'm fine with adding the field, I just don't want people to complain later.

@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag labels Feb 1, 2018
@bhousel bhousel closed this as completed in 42dd36a Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

2 participants