Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset for amenity=pharmacy unexpectedly adds dispensing=yes #627

Closed
ghost opened this issue Oct 29, 2022 · 4 comments
Closed

Preset for amenity=pharmacy unexpectedly adds dispensing=yes #627

ghost opened this issue Oct 29, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Oct 29, 2022

I usually contribute to the Name Suggestion Index, but when I tried to correct it, I didn't see that field, so I'm opening the issue as I think the problem is probably here.
I am sorry if this is wrong.

In Japan, drug stores are basically added with this preset (tag), but an unexpected dispensing=yes is added.
Since not all stores have dispensing available, I would like to have it not added automatically, is this possible?

@ghost ghost changed the title Preset for amenity=pharmacy with dispensing=yes added unexpectedly Preset for amenity=pharmacy unexpectedly adds dispensing=yes Oct 29, 2022
@ghost ghost changed the title Preset for amenity=pharmacy unexpectedly adds dispensing=yes Preset for amenity=pharmacy unexpectedly adds dispensing=yes Oct 29, 2022
@LaoshuBaby
Copy link

The original PR is osmlab/name-suggestion-index#7277

I merged that because its changes looks good for NSI, but unexpectedly tags problem can't be solved by me.

@tyrasd
Copy link
Member

tyrasd commented Oct 31, 2022

The default was added in the course of resolving openstreetmap/iD#4763, but I don't find a source why the default value of yes should be assumed for all pharmacies everywhere. Let's drop the default value. Btw: This will mean that any of the pharmacy brands in NSI, which do always dispense prescriptions (e.g. in Japan) should probably receive the dispensing=yes tag in the NSI repo.

@tyrasd tyrasd closed this as completed in d2e8e87 Oct 31, 2022
@bhousel
Copy link
Member

bhousel commented Oct 31, 2022

Oh - yeah I forgot about this, but we can just remove the field in the NSI script that builds the presets. dispensing=* has never made sense to me.

@ghost
Copy link
Author

ghost commented Nov 1, 2022

Thank you for resolving this issue. It has been bothering me for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants