Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pharmacy Tsuruha (調剤薬局ツルハドラッグ) #7277

Merged
merged 1 commit into from Oct 29, 2022
Merged

Add Pharmacy Tsuruha (調剤薬局ツルハドラッグ) #7277

merged 1 commit into from Oct 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2022

I added the dispensary portion because it seems to be treated as a separate store brand.


Not directly related to this PR, but how can I prevent dispensing=yes from being automatically added in the amenity=pharmacy and healthcare=pharmacy presets?
In Japan, drug stores are added with this preset (tags), but not all stores have dispensing available, like the brand I have just added.

I didn't see it in the NSI json, so is it necessary to change the code of the iD preset?

@LaoshuBaby
Copy link
Collaborator

Not directly related to this PR, but how can I prevent dispensing=yes from being automatically added in the amenity=pharmacy and healthcare=pharmacy presets?
In Japan, drug stores are added with this preset (tags), but not all stores have dispensing available, like the brand I have just added.

I didn't see it in the NSI json, so is it necessary to change the code of the iD preset?

Looks like this can't be solved in NSI because this was pharmacy's preset, stored in there:
https://github.com/openstreetmap/id-tagging-schema/blob/abe59b253d30cb02ef1d491fe937fbafdcd746fb/data/presets/amenity/pharmacy.json#L3-L11
I suggest that you open a issue in that repository.

@ghost
Copy link
Author

ghost commented Oct 29, 2022

Looks like this can't be solved in NSI because this was pharmacy's preset, stored in there: https://github.com/openstreetmap/id-tagging-schema/blob/abe59b253d30cb02ef1d491fe937fbafdcd746fb/data/presets/amenity/pharmacy.json#L3-L11 I suggest that you open a issue in that repository.

Thank you very much, I will try to open an issue in that repository.

PS: Opened issue as openstreetmap/id-tagging-schema#627.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant