Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kurdish translation #4783

Closed
2 tasks done
bhousel opened this issue Feb 9, 2018 · 10 comments
Closed
2 tasks done

Fix Kurdish translation #4783

bhousel opened this issue Feb 9, 2018 · 10 comments
Labels
localization Adapting iD across languages, regions, and cultures

Comments

@bhousel
Copy link
Member

bhousel commented Feb 9, 2018

per openstreetmap/openstreetmap-website#1413
It looks like our current translation ku.json should really be ckb.json to better match the osm.org website. (ku should be written in Latin, ckb in Arabic)

Todo:

  • Upload all of the ku translations to Transifex as ckb
  • Empty the ku translation so that people can translate it the other way
@bhousel bhousel added the localization Adapting iD across languages, regions, and cultures label Feb 9, 2018
@bhousel
Copy link
Member Author

bhousel commented Feb 10, 2018

This was done!
cc @Ghybu - Please spread the word, if you know anyone who is able to help us with the ku or ckb translations.

You can sign up and join these translation teams here: https://transifex.com/openstreetmap/id-editor/

@bhousel bhousel closed this as completed Feb 10, 2018
@1ec5
Copy link
Collaborator

1ec5 commented Feb 10, 2018

This is now consistent with wmf-sitematrix as well. 👍 (The Kurdish Wikipedia can be displayed in either Arabic or Latin script, but Latin is the default.)

https://github.com/osmlab/wmf-sitematrix/blob/deeeccc1212bb26800fc67cf17ea1ab227d27f9e/wikipedia.json#L672-L676
https://github.com/osmlab/wmf-sitematrix/blob/deeeccc1212bb26800fc67cf17ea1ab227d27f9e/wikipedia.json#L227-L231

@Ghybu
Copy link

Ghybu commented Mar 5, 2018

@1ec5 @bhousel
Thanks. But for the "ku" or "ku-latn" code (Latin script ) the layout of the page must be in LTR and for the "ckb" code (Arabic script ) the layout must be in RTL.
Currently, it's the opposite.

@bhousel
Copy link
Member Author

bhousel commented Mar 5, 2018

Oh thanks for flagging ... It looks wrong here, and this is a value that I expected Transifex to update for us:

iD/data/locales.json

Lines 30 to 32 in 837b297

"ckb": {
"rtl": false
},

@bhousel bhousel reopened this Mar 5, 2018
@Ghybu
Copy link

Ghybu commented Mar 5, 2018

Sorry to come back again and again on this topic :)

Line 126 / 127 must also be modified. As I said above, actualy "ku" and "ku-latn" is in RTL. It should be in LTR.

Another thing: when I choose "ku" in "My Settings --> Preferred Languages". I don't see a translation in Kurdish. Normally "ku" and "ku-latn" should give the same thing.

@bhousel
Copy link
Member Author

bhousel commented Mar 5, 2018

No apology needed, we want to get this right 👍
If Transifex is returning the wrong thing for these languages, we'll just hardcode the correct thing in our update_locales.js script. I have to investigate whether the result is wrong or whether there is an issue in our query.

getLanguageInfo(code, function(err, info) {
dataLocales[code] = { rtl: info && info.rtl };
done();

@bhousel
Copy link
Member Author

bhousel commented Mar 5, 2018

Transifex is indeed returning the opposite of what we expect:

12:20 $ curl -i -L -X GET https://www.transifex.com/api/2/language/ckb

{
    "rtl": false, 
    "pluralequation": "language.pluralequation", 
    "code": "ckb", 
    "name": "Central Kurdish", 
    "nplurals": 2
}

12:20 $ curl -i -L -X GET https://www.transifex.com/api/2/language/ku

{
    "rtl": true, 
    "pluralequation": "language.pluralequation", 
    "code": "ku", 
    "name": "Kurdish", 
    "nplurals": 2
}

@1ec5
Copy link
Collaborator

1ec5 commented Mar 5, 2018

For reference, CLDR defines ckb’s script as Arabic and ku’s script as either Cyrillic or Latin (with Arabic being a non-primary script). CLDR also defines Arabic as being written right-to-left as part of its script metadata. These files can be useful for discovering other special cases we may need to add.

@Ghybu
Copy link

Ghybu commented Mar 5, 2018

Kurdish is written in Arabic script or in Latin. Cyrillic script is no longer used.

Concerning the CLDR, see these discussions:

See also (phabricator):

And (OSM wiki)

@bhousel bhousel closed this as completed in 13789cc Mar 6, 2018
@bhousel
Copy link
Member Author

bhousel commented Mar 6, 2018

I opened an issue with Transifex support, and they're looking into the issue. In the meantime, I just hardcoded the RTL/LTR values in 13789cc so we can close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

No branches or pull requests

3 participants