Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support {header()} in Custom Background URLs #4812

Closed
jidanni opened this issue Feb 17, 2018 · 5 comments
Closed

support {header()} in Custom Background URLs #4812

jidanni opened this issue Feb 17, 2018 · 5 comments
Labels
wontfix-impossible Not possible to do in a browser app or with OpenStreetMap

Comments

@jidanni
Copy link
Contributor

jidanni commented Feb 17, 2018

Please see
https://help.openstreetmap.org/questions/55267/strava-heatmap-does-not-appear-anymore?page=1&focusedAnswerId=55381#55381

@jidanni
Copy link
Contributor Author

jidanni commented Feb 17, 2018

Also at the bottom of https://josm.openstreetmap.de/wiki/Maps

Normally JOSM ignores any elements that it does not recognize. However, it will skip the entire imagery entry, when one of the unsupported tags has the attribute mandatory='true'.

So iD, instead of sending such {header()} etc. unknown elements down the pipe, still hanging on to the back of the URL, should at least strip them...

@bhousel
Copy link
Member

bhousel commented Feb 17, 2018

Unfortunately that's not really possible to adjust the referrer header from within a web application. The browser sets it for us and we can't change it. Sorry!

This also came up for discussion on #3420

@bhousel bhousel closed this as completed Feb 17, 2018
@bhousel bhousel added the wontfix-impossible Not possible to do in a browser app or with OpenStreetMap label Feb 17, 2018
@jidanni
Copy link
Contributor Author

jidanni commented Feb 17, 2018

OK, but it "behooves" you to throw an error:

Dear User: you tried to use a directive(s) [norflesburg, header] that we
 did not understand or cannot support, within your URL template.

Rather than sending your directive, still embedded in the URL
uninterpreted, to the server, which would be ** NEVER what your intended
** and indeed ** possibly quite embarrassing ** and just plain looks silly too,
please instead clean up your URL template, and reesubmit it.

@bhousel
Copy link
Member

bhousel commented Feb 17, 2018

OK, but it "behooves" you to throw an error:

Isn't raising errors about custom imagery covered in one of the other half dozen issues you just opened?

@jidanni
Copy link
Contributor Author

jidanni commented Feb 17, 2018

I don't see any for "catch unsupported URL template directives (that
should never be sent raw)'

Wait, I found it........

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix-impossible Not possible to do in a browser app or with OpenStreetMap
Projects
None yet
Development

No branches or pull requests

2 participants