Replace wkid/w/s/n/e in WMS URL templates #5738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
{wkid}
,{w}
,{s}
,{n}
, and{e}
tokens in WMS-style background imagery templates, as described in this JOSM documentation.The
{wkid}
token is particularly handy forexportImage
endpoints in ArcGIS ImageServer services. (In fact, it appears multiple times, whereas the previous code only replaced each token once.) Currently, osmlab/editor-layer-index#611 works around the lack of this token by hard-coding a projection, but JOSM can use theprojection
property correctly: osmlab/editor-layer-index@95680b2#r31964799. Once this PR lands, we can modify the editor layer index’s tests to accept{wkid}
as an alternative to{proj}
.Thanks to @don-vip for making me aware of these additional tokens.