Address preset is using the wrong values for Australia.

[FrakGart]

In Australia street addresses are addr:suburb not addr:city and addr:state not addr:province. So for example:
https://api.openstreetmap.org/api/0.6/node/5621132293/1

Moorabbin is a suburb in the city of Melbourne and Victoria is a state not a province.

[bhousel]

Hey @FrakGart - the address formats are defined in this file:
https://github.com/openstreetmap/iD/blob/master/data/address-formats.json

It looks like Australia is currently set to use the same format as Canada.

iD/data/address-formats.json

Lines 71 to 75 in 837d4b7

	"countryCodes": ["au","ca"],
	"format": [
	["housenumber", "street", "unit"],
	["city", "province", "postcode"]
	]

[tastrax]

https://auspost.com.au/content/dam/auspost_corp/media/documents/australia-post-addressing-standards-1999.pdf

is a great guide but I am no coder maybe this as the most basic form

"countryCodes": ["au"],
"format": [
["unit", "housenumber", "street",],
["suburb", "state", "postcode"]
]

[bhousel]

Thanks @tastrax and @FrakGart - I've added the format to the list.

It shows like this when editing in Australia:

[FrakGart]

@bhousel Thanks for that. Looks much better.

Had not noticed the addr:unit was in the wrong place so thanks @tastrax.

[andrewharvey]

Thanks for catching that @FrakGart! Agreed it's much better now @bhousel with your commit.

[maraf24]

Overpass query (http://overpass-turbo.eu/s/zCX) reveals 5500 nodes and ways with addr:suburb in Perth area and 54000 for addr:city tag.
For Melbourne area I got 37000 addr:suburbs and 70000 addr:city, however over 36000 addr:suburbs has also addr:city. Example: https://www.openstreetmap.org/way/44222946

It looks for me that addr:city is widely used in Australia, as addition to addr:suburb or sometimes instead. The stats show it prevails over addr:suburb.

I would like to suggest to restore addr:city in format address in Australia as it is either used/necessary or needs to be cleaned/moved to suburb field.

Btw, what is rationale for "Address preset is using the wrong values for Australia."?
The wiki page https://wiki.openstreetmap.org/wiki/Australian_Tagging_Guidelines doesn't contain any information regarding addr: tags.

[andrewharvey]

It looks for me that addr:city is widely used in Australia, as addition to addr:suburb or sometimes instead. The stats show it prevails over addr:suburb.

@tastrax Linked to the Australia Post reference in #5039 (comment). The postal address must always contain the "Placename/suburb/locality", not the city. So the addr:city usage in Australia is technically wrong, but to be honest I don't see it as a big issue since they can all be treated interchangeably as placename/suburb/locality and any data consumers should treat the addr:city value as a placename/suburb/locality not a city.

Looking forward though, it's probably not a good idea to say in Australia addr:city isn't actually the city, so best we start migrating to addr:suburb (valid point that now we're overflowing addr:suburb with placename/locality).

It's likely the prevailing tag because addr:suburb was only created in 2012 and it's too easy to mistakenly use addr:city.

I've used addr:city myself, but I've always been tagging the suburb, not the city, so it should have been addr:suburb.

I would like to suggest to restore addr:city in format address in Australia as it is either used/necessary or needs to be cleaned/moved to suburb field.

I think we should leave it as is per this PR, with addr:suburb and not addr:city for the reasons above.

[tastrax]

Example: https://www.openstreetmap.org/way/44222946

Unfortunately that appears to be a bad example as its not in the city of Melbourne

https://whatson.melbourne.vic.gov.au/Pages/map.aspx

Its actually in the City of Knox. https://en.wikipedia.org/wiki/City_of_Knox

Lots of folks simply don't know which 'city' they reside in and in Australia its not used as part of any postal address like province/counties etc are in other countries

I think it should be left as is.

[FrakGart]

The wiki entry https://wiki.openstreetmap.org/wiki/Key:addr#For_countries_using_hamlet.2C_subdistrict.2C_district.2C_province.2C_state has had a note abut the definition of suburb for Australia for a while now.

[andrewharvey]

Lots of folks simply don't know which 'city' they reside in and in Australia its not used as part of any postal address like province/counties etc are in other countries

The "City of..." or "...City Council" is the Local Government Area, not the city like Melbourne, Bendigo, Wangaratta, neither are used in addressing.

Let's not forget that a suburbs/localities are mapped as admin boundaries, and most addressees can have their suburb field derived from that admin boundary, so actually populating the suburb isn't super critical most of the time.

[FrakGart]

@andrewharvey that depends on if your address happens to be in NSW/Vic/SA otherwise there are no admin boundaries to work off.