Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create preset for leisure=bandstand #5262

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

AndreasHae
Copy link
Contributor

Fixes #5259

@vershwal
Copy link
Collaborator

Hey @AndreasHae. Looks good, but you need to run npm run build before pushing any code, this command will build your project and also notify if there is any error. In your case after adding data/presets/presets/leisure/bandstand.json if you run npm run build it will update the following four files :
data/presets.yaml
data/presets/presets.json
data/taginfo.json
dist/locales/en.json

I would suggest you to build the code and push the changes again.
Thanks!!

@bhousel
Copy link
Member

bhousel commented Sep 4, 2018

Thanks @AndreasHae - I'm going to merge and change the building tag from the "tags" to its own field.

Talking about this part:

    "tags": {
        "leisure": "bandstand",
        "building": "roof"
    },

Everything in the tag list is required in order for the preset to be matched. This means that the way the preset is currently set up, if a bandstand didn't have exactly building=roof it would not be recognized as a bandstand. So I'm going to put the building tag into a field instead, just in case people tagged it as building=yes,building=gazebo,building=shelter,building=bandstand or some other thing.

@bhousel bhousel merged commit e1ac522 into openstreetmap:master Sep 4, 2018
bhousel added a commit that referenced this pull request Sep 4, 2018
@freeExec
Copy link

freeExec commented Sep 4, 2018

The tag building is not is not needed here.

@bhousel
Copy link
Member

bhousel commented Sep 4, 2018

The tag building is not is not needed here.

Actually it is.

@AndreasHae AndreasHae deleted the 5259-bandstand-preset branch September 5, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants