Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for amenity=language_school #5261

Merged

Conversation

AndreasHae
Copy link
Contributor

@AndreasHae AndreasHae commented Aug 27, 2018

Fixes #5245

I had to omit the field for "language" for now, because I could not find a proper way to add it. I guess this functionality has yet to be implemented. If there is already a way, please let me know.

@AndreasHae AndreasHae changed the title Add preset for amenity=language_school (closes issue 5245) Add preset for amenity=language_school (closes #5245) Aug 27, 2018
@AndreasHae AndreasHae changed the title Add preset for amenity=language_school (closes #5245) Add preset for amenity=language_school Aug 27, 2018
@vershwal
Copy link
Collaborator

npm run build as suggested here.

@bhousel
Copy link
Member

bhousel commented Sep 4, 2018

Thanks @AndreasHae , I'll merge and rebuild..

I had to omit the field for "language" for now, because I could not find a proper way to add it. I guess this functionality has yet to be implemented. If there is already a way, please let me know.

I can add a multiselect field for languages, but it won't support the main/yes style of tagging.. just yes or nothing

@AndreasHae
Copy link
Contributor Author

Sorry, I was busy in the last days. @bhousel thanks for taking a look. May I ask if you have some other issues for me to work on.. maybe something more Javascript-related/advanced?

@bhousel bhousel merged commit 3011333 into openstreetmap:master Sep 4, 2018
@bhousel
Copy link
Member

bhousel commented Sep 4, 2018

I can add a multiselect field for languages, but it won't support the main/yes style of tagging.. just yes or nothing

btw I changed my mind about this part - the language field will support 'main' if people want to add it in the raw tag editor. see #5291

@bhousel
Copy link
Member

bhousel commented Sep 4, 2018

Sorry, I was busy in the last days. @bhousel thanks for taking a look. May I ask if you have some other issues for me to work on.. maybe something more Javascript-related/advanced?

Thanks! There are so many issues.. The "help wanted" ones are a good place to start, but don't limit yourself to that. Maybe read through the whole list and see if anything sounds interesting?

@AndreasHae AndreasHae deleted the 5245-language-school-preset branch September 5, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants