Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geodatastyrelsen_Denmark background not available over Bornholm #5264

Closed
Thue opened this issue Aug 28, 2018 · 3 comments
Closed

Geodatastyrelsen_Denmark background not available over Bornholm #5264

Thue opened this issue Aug 28, 2018 · 3 comments
Labels
bug A bug - let's fix this! help wanted For intermediate contributors, requires investigation or knowledge of iD code

Comments

@Thue
Copy link
Contributor

Thue commented Aug 28, 2018

For Denmark, the Geodatastyrelsen_Denmark background ortophotos are the best and the recommended background imagery.

However, they seem not to be selectable over Bornholm: https://thuejk.dk/whereissdfe.png . They work fine for the rest of Denmark.

Looking at https://raw.githubusercontent.com/openstreetmap/iD/master/data/imagery.json , there is the following polygon, which seems like it should make them available over Bornholm:

    [
      [14.68259, 55.36394],
      [14.83952, 55.35652],
      [14.82638, 55.26713],
      [15.13934, 55.25174],
      [15.1532, 55.34108],
      [15.30992, 55.33306],
      [15.29572, 55.24374],
      [15.13934, 55.25174],
      [15.12556, 55.16238],
      [15.28158, 55.15442],
      [15.25356, 54.97576],
      [14.63175, 55.00625],
      [14.68259, 55.36394]
    ]
@NKAmapper
Copy link

NKAmapper commented Aug 28, 2018

In fact none of the Danish imagery maps are displayed in the Background menu when panning over Bornholm. All the boundaries in ELI already cover Bornholm. They are discovered over Bornholm in JOSM and in Go Map.

@bhousel
Copy link
Member

bhousel commented Aug 29, 2018

related #5250
I'll check next week what's going on.

@bhousel bhousel added the bug A bug - let's fix this! label Sep 1, 2018
@bhousel bhousel added the help wanted For intermediate contributors, requires investigation or knowledge of iD code label Oct 15, 2018
@bhousel bhousel closed this as completed in 4632625 Nov 8, 2018
@bhousel
Copy link
Member

bhousel commented Nov 8, 2018

This is working now! The polygon array was being treated as an outer with holes, and I needed to rewrite it to be an array of outers.

#5250 #5264 #5272 were all the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! help wanted For intermediate contributors, requires investigation or knowledge of iD code
Projects
None yet
Development

No branches or pull requests

3 participants