-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "reset all" button to background display options #5503
Comments
@bhousel May I start working on this issue?? |
@hardik-codes I don't think anyone else has started it so go ahead! |
Ok then @quincylvania |
Yes @hardik-codes - for this one, just add a small link with the text "reset all" somewhere in the bottom of the pane. |
Would love to work on this as my first issue. (if no one else is) @bhousel @quincylvania |
@co16353sidak I'm not sure if @hardik-codes still plans to submit a PR but it's been awhile so you can probably give it a try! |
@quincylvania If you can give me a suggestion on where to start that would be wonderful. |
@co16353sidak You'll want to add the button to the bottom of modules/ui/background_display_options.js. To add the translatable label text, add a value to data/core.yaml and reference it with the I hope that's enough to get you started! Feel free to reach out to me or the iD channel on the OSM US Slack. |
Hi @quincylvania, if its still open, I can help :) |
@SahibArora Well no one has submitted a PR yet so feel free to try it! |
Thank you! @hikemaniac, I will give it a shot |
Hi @quincylvania, I am attempting this too, I did the functionality and it works but the Also, Could I please have an invite for the slack group to ask further questions. (email - athif.shaffy@gmail.com ) |
@alphagamer7 Hmm I've never seen that error but it looks like a syntax problem. Try not using newer JavaScript features 😅 You can sign up for slack yourself here. Turns out I posted the wrong link for that! |
Ok, then @alphagamer7, you go for it. Thanks @quincylvania for the chance, I will have a look if I could help in anything else. |
I often tune up brightness and contrast for some spots of the aerial imagery, where the image is very dark. Occasionally I change other values as well. As soon as I leave these dark spots I don't need the effects anymore and I have to reset every option manually. In such cases it would be helpful to have a "reset all"-button. Is it possible to add such a minor but time-saving feature?
Related to #4789
The text was updated successfully, but these errors were encountered: