Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New presets for name-suggestion-index v1 #5510

Closed
bhousel opened this issue Nov 21, 2018 · 0 comments
Closed

New presets for name-suggestion-index v1 #5510

bhousel opened this issue Nov 21, 2018 · 0 comments
Assignees
@quincylvania
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag

Comments

@bhousel
Copy link
Member

bhousel commented Nov 21, 2018 •
edited
Loading

#5507 upgrades the name-suggestion-index used by iD..
The new index has much higher quality brand suggestions 👍

But we are getting these warnings now for entries from the index that do not have a corresponding preset in iD. We should add presets for these things:

Warning: No preset "amenity/money_transfer" for name-suggestion "Express Union"
Warning: No preset "amenity/money_transfer" for name-suggestion "Western Union"
Warning: No preset "amenity/payment_centre" for name-suggestion "Rapipago"
Warning: No preset "amenity/payment_terminal" for name-suggestion "Qiwi"
Warning: No preset "shop/catalogue" for name-suggestion "Argos"
Warning: No preset "shop/country_store" for name-suggestion "Rural King"
Warning: No preset "shop/country_store" for name-suggestion "Tractor Supply Company"
Warning: No preset "shop/hairdresser_supply" for name-suggestion "Sally Beauty Supply"
Warning: No preset "shop/party" for name-suggestion "Party City"
@bhousel bhousel added new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag labels Nov 21, 2018
@quincylvania quincylvania self-assigned this Nov 22, 2018
@quincylvania quincylvania added the wip Work in progress label Nov 22, 2018
quincylvania added a commit to quincylvania/iD that referenced this issue Nov 22, 2018
@quincylvania
Adds the missing presets for name-suggestion-index v1.
51e5e59 
Closes openstreetmap#5510
@quincylvania quincylvania mentioned this issue Nov 22, 2018
Merged
@bhousel bhousel removed wip Work in progress labels Dec 2, 2018
@bhousel bhousel mentioned this issue Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhousel @quincylvania