Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent browser page navigation when panning with trackpad or magic mouse #5552

Closed
quincylvania opened this issue Dec 5, 2018 · 4 comments
Closed

Prevent browser page navigation when panning with trackpad or magic mouse #5552

quincylvania opened this issue Dec 5, 2018 · 4 comments
Assignees
@quincylvania
Labels
bug A bug - let's fix this! usability An issue with ease-of-use or design
Milestone
2.18.0

Comments

@quincylvania
Copy link
Collaborator

Starting a pan with a horizontal gesture can cause the browser to navigate between pages in the tab's history, thus inadvertently closing iD.

  • iD 2.12.0
  • Safari, Chrome
  • macOS 10.14
  • Apple trackpad, magic mouse
@quincylvania quincylvania added bug A bug - let's fix this! usability An issue with ease-of-use or design labels Dec 5, 2018
@bhousel
Copy link
Member

bhousel commented Dec 11, 2018

I think #5505 might make it more possible to fix this

@bhousel bhousel added the help wanted For intermediate contributors, requires investigation or knowledge of iD code label Dec 19, 2018
@jfirebaugh jfirebaugh mentioned this issue Feb 18, 2019
Open
@sookoll
Copy link

sookoll commented Feb 18, 2019

Well You can just remove this horrible two fingers panning and You are all good. I stopped editing OSM after You made this change, because it is just frustrating.

@bhousel
Copy link
Member

bhousel commented Feb 19, 2019

Well You can just remove this horrible two fingers panning and You are all good. I stopped editing OSM after You made this change, because it is just frustrating.

Sorry to see you go, but hope you will consider using another editor to continue to contribute to OSM.

@quincylvania quincylvania self-assigned this Mar 10, 2020
@quincylvania quincylvania added this to the Next Release milestone Mar 10, 2020
@quincylvania quincylvania removed the help wanted For intermediate contributors, requires investigation or knowledge of iD code label Mar 10, 2020
@quincylvania
Copy link
Collaborator Author

I found a solution for this that works for a Macbook trackpad in testing. I don't have a magic mouse for testing at the moment but I expect this solution will also fix panning on that device.

zlavergne pushed a commit to KaartGroup/iD that referenced this issue Mar 10, 2020
@quincylvania @zlavergne
Fix issue where browsers could page back or forward when swiping hori…
e85e790 
…zontally over the map with a trackpad (close openstreetmap#5552)
@quincylvania quincylvania modified the milestones: 3.0.0, 2.18.0 May 5, 2020
@quincylvania quincylvania mentioned this issue Jun 4, 2020
Closed
@quincylvania quincylvania mentioned this issue Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
bug A bug - let's fix this! usability An issue with ease-of-use or design
Projects
None yet
Milestone
2.18.0
Development

No branches or pull requests
3 participants
@bhousel @sookoll @quincylvania