Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field autocomplete can overwrite input #5618

Closed
rivermont opened this issue Dec 17, 2018 · 2 comments · Fixed by #5637
Closed

Field autocomplete can overwrite input #5618

rivermont opened this issue Dec 17, 2018 · 2 comments · Fixed by #5637
Assignees
@maxgrossman
Labels
bug A bug - let's fix this!

Comments

@rivermont
Copy link
Contributor

When entering custom tag data, there is a condition in which the autocompleted key or value will overwrite the user input after the type something else.
Similar to #2376.

Steps to Reproduce

  • Start typing in something that will autocomplete
  • Allow the highlighted autocomplete text to appear
  • Keep typing through that, but anything different than was going to autocomplete
  • Tab into the next field

What you typed will be gone and replaced by the autocompleted text.

Tested in Vivaldi and Firefox on Ubuntu 18.04.
@bhousel bhousel added the bug A bug - let's fix this! label Dec 19, 2018
@bhousel
Copy link
Member

bhousel commented Dec 19, 2018

Thanks @rivermont , sounds like a bug

maxgrossman added a commit that referenced this issue Dec 20, 2018
@maxgrossman
default to value() if neither d and choice are null in the accept fun…
2dab19e 
…ction

ref #5618
@maxgrossman maxgrossman mentioned this issue Dec 20, 2018
Merged
@bhousel
Copy link
Member

bhousel commented Dec 26, 2018

I think this was fixed in #5637?

@bhousel bhousel closed this as completed Dec 26, 2018
bhousel added a commit that referenced this issue Jan 23, 2019
@bhousel
Improve combobox event handling and avoid overwriting typed data
0c7b9a6 
(closes #5722, re: #5637, re: #5618)

dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)

Fix for this coming in next commit.
bhousel added a commit that referenced this issue Jan 23, 2019
@bhousel
Make sure all combo event listeners can handle accept/cancel w/o datum
4583e2d 
(re: #5637, re: #5618)

This can happen if the user enters a value that is not matched to
one of the combo suggestions.

Also make sure to set `this` to the input field.  It might not be
already if the event was triggered from a keypress instead of a click.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxgrossman maxgrossman

Labels
bug A bug - let's fix this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix autocomplete combobox bug openstreetmap/iD
3 participants
@bhousel @maxgrossman @rivermont