Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open combobox if anywhere on box clicked... #5636

Merged
merged 2 commits into from
Dec 20, 2018
Merged

open combobox if anywhere on box clicked... #5636

merged 2 commits into from
Dec 20, 2018

Conversation

maxgrossman
Copy link
Collaborator

closes #5596

@maxgrossman maxgrossman requested a review from bhousel December 20, 2018 13:52
@bhousel
Copy link
Member

bhousel commented Dec 20, 2018

Looks ok, thanks @maxgrossman!
We really should figure out what's wrong with that one Wikipedia test on Node 10 🤔

@bhousel bhousel merged commit e2c0f5e into master Dec 20, 2018
@bhousel bhousel deleted the 5596 branch December 20, 2018 15:09
@bhousel bhousel mentioned this pull request Jan 18, 2019
Closed
@quincylvania quincylvania mentioned this pull request Jan 23, 2019
Merged
@my-na-me my-na-me mentioned this pull request Jan 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhousel bhousel Awaiting requested review from bhousel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combobox should toggle on clicking anywhere on the field, not just the carat
2 participants
@maxgrossman @bhousel