Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open combobox if anywhere on box clicked coming from auto-filled key-box #5752

Closed
my-na-me opened this issue Jan 24, 2019 · 2 comments
Closed
Labels
field An issue with a field in the user interface
Milestone

Comments

@my-na-me
Copy link

Starting from:
Usability >> Open the combobox when clicking anywhere in the text field (#5596, #5636, thanks @maxgrossman)

There is a minor additional request for potential usability optimization.

The opening of the combobox is working well for a lot of situations now, but it will not happened when you come before from an auto-filled key box (left-hand side), see movie:
.
open combo box after autofill

@bhousel
Copy link
Member

bhousel commented Jan 24, 2019

One of the issues with our combobox control is that - it dispatches accept and cancel events so that calling components can adjust the value selected (for example to check that the string entered or autocompleted is really a valid thing). These events fire on a bunch of different triggers, but they do not fire on blur (field loses focus), and they probably should be changed to fire there only (not on tab, return, click, etc).

I did a bunch of work 2 days ago in 4583e2d and 0c7b9a6 to fix some issues caused by the event firing and autocomplete and situations that can break places that comboboxes are used. It's pretty complicated, but before I forget everything I learned, I'd like to spend another day on improving the combobox to be more reliable.

(this comment is probably really only helpful for my own memory and doesn't make much sense to anyone else reading - sorry)

@bhousel bhousel added the field An issue with a field in the user interface label Jan 25, 2019
@my-na-me
Copy link
Author

(this comment is probably really only helpful for my own memory and doesn't make much sense to anyone else reading - sorry)

no, no. Thanks for the internal details. I can image is work on the core unit of combobox handling. And I think the mentioned function would be a kind of great unique feature of iD (and would speed up the editing and it would stimulate iD user to be happy and use it even longer as scheduled :-).
Now in the meantime I was a bit curious and looked at how the other programs have implemented it. See next 3 movies (btw, on the very last the action of the third movie, JOSM has also an minor bug and after selecting "yes" the box is empty ;-) ):

A known search engine doing it this style, click to nowhere:
combobox google4
.
.
.
.
.
.

another OSM editor, 1. click to combobox field (key/value was not used before):
combobox josm click box first new key value xxx

.
.
.
.
.
.
..

another OSM editor, 2. click to carat (key/value was used before):
combobox josm click box first new key value xxx2

bhousel added a commit that referenced this issue Jan 25, 2019
(re: #5752 - but does not close it)
@bhousel bhousel added this to the 2.13.1 milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field An issue with a field in the user interface
Projects
None yet
Development

No branches or pull requests

2 participants