Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For linked data, should help link to real wikidata instead of OSM wiki? #5823

Closed
bhousel opened this issue Jan 28, 2019 · 9 comments
Closed
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@bhousel
Copy link
Member

bhousel commented Jan 28, 2019

This looks weird to me:

screenshot 2019-01-28 13 34 58

Maybe for the name/brand fields on a feature that's linked to wikidata, we should follow the wikidata link and get Starbucks's info, rather than show the OSM documentation.

@bhousel
Copy link
Member Author

bhousel commented Jan 28, 2019

BTW, and offtopic, but "The primary tag used for naming an element." is not very beginner friendly.

@1ec5
Copy link
Collaborator

1ec5 commented Jan 29, 2019

Is it weird because the prepopulated name looks like the thing being documented? I guess the documentation has always been misplaced from an information architecture standpoint. How wedded are we to this slide-in-below-the-field treatment, versus a help bubble or a row inserted right below the field’s header?

BTW, and offtopic, but "The primary tag used for naming an element." is not very beginner friendly.

Reworded the description.

@bhousel
Copy link
Member Author

bhousel commented Jan 29, 2019

Showing the preset documentation looks even more funny:

screenshot 2019-01-29 13 27 50

@bhousel
Copy link
Member Author

bhousel commented Jan 29, 2019

How wedded are we to this slide-in-below-the-field treatment, versus a help bubble or a row inserted right below the field’s header?

Not totally wedded, but this approach works mostly ok. It's useful that the space can show things of arbitrary length and with or without a picture.

@kymckay
Copy link
Collaborator

kymckay commented Jan 29, 2019

🤔 I think showing the brand information doesn't provide much value to a map editor (other than perhaps confirming it's the right brand of that name). However, I see your point that it's a little funny to provide information on a field the user can't interact with.

@1ec5
Copy link
Collaborator

1ec5 commented Feb 1, 2019

How about placing the non-brand preset name, or the wikidata item’s label, in a header immediately above the documentation? That way at least it’s clear what the documentation refers to, even when it isn’t especially relevant.

@bhousel bhousel added the question Not Actionable - just a question about something label Feb 2, 2019
@bhousel
Copy link
Member Author

bhousel commented Feb 8, 2019

It's gotten worse.. check out this guy in the bowtie :bowtie: :
screenshot 2019-02-08 14 05 34

bhousel added a commit that referenced this issue Feb 8, 2019
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
@bhousel
Copy link
Member Author

bhousel commented Feb 8, 2019

We're looking these up from real wikidata now. Thanks for ruining my afternoon, bowtie dude. 😆
A few more things:

  • Add proper sitelinks
  • They don't work the first time, but they work after that. Need to figure out why.

screenshot 2019-02-08 16 30 33

@bhousel bhousel added preset An issue with an OpenStreetMap preset or tag and removed question Not Actionable - just a question about something labels Feb 8, 2019
bhousel added a commit that referenced this issue Feb 9, 2019
@bhousel
Copy link
Member Author

bhousel commented Mar 21, 2019

This was done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants