Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw editor - alphabetic order changes after modifing tag-key #5927

Closed
sun-geo opened this issue Feb 22, 2019 · 1 comment
Closed

raw editor - alphabetic order changes after modifing tag-key #5927

sun-geo opened this issue Feb 22, 2019 · 1 comment
Assignees
@bhousel
Labels
bug A bug - let's fix this!
Milestone
2.15.0

Comments

@sun-geo
Copy link
Contributor

sun-geo commented Feb 22, 2019

Corresponding to #5925 there is another new behavior for v2.14 detected which is sorting related.

If a tag-key is modified the whole line doesn't stay in the alphabetic order and is moving to the bottom

Expected behavior: Line order shouldn't change and remain contant

For an example see here:
sorting
@quincylvania quincylvania added the bug A bug - let's fix this! label Feb 22, 2019
@bhousel bhousel self-assigned this Apr 3, 2019
@sun-geo
Copy link
Contributor Author

sun-geo commented May 1, 2019

Thank you :-)

bhousel added a commit that referenced this issue May 1, 2019
@bhousel
When removing a tag, remove it from _indexedKeys too
087f252 
(re: d026f2f / #5927)

So that if the user decides to put it back, it will be sorted to the
end and not inserted back at its original position in the middle
@bhousel bhousel added this to the 2.15.0 milestone May 2, 2019
@bhousel bhousel mentioned this issue May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhousel bhousel

Labels
bug A bug - let's fix this!
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
3 participants
@bhousel @quincylvania @sun-geo