Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display preset in issue message #5929

Closed
boothym opened this issue Feb 22, 2019 · 3 comments
Closed

Display preset in issue message #5929

boothym opened this issue Feb 22, 2019 · 3 comments
Labels
considering Not Actionable - still considering if this is something we want validation An issue with the validation or Q/A code

Comments

@boothym
Copy link
Contributor

boothym commented Feb 22, 2019

I came across an issue which said " crosses Foot Path". I was confused at first until I realised the first part was referring to a railway line.

It seems the object name replaces the preset name in the issue message. I think it would be a good idea to display both, to tell users what type of object is causing an issue?

For example: Rail () crosses Foot Path (name of path) would be better IMO

@quincylvania quincylvania added considering Not Actionable - still considering if this is something we want validation An issue with the validation or Q/A code labels Feb 22, 2019
@quincylvania
Copy link
Collaborator

Hmm maybe! We do kinda do this for the relation member list. The downside would be longer issues, which is especially a problem for ways with lots of crossings.

Contra Costa County Road 120 (Minor/Unclassified Road) crosses Concord Subdivision (Disused Railway)
Contra Costa County Road 120 (Minor/Unclassified Road) crosses Concord Subdivision (Disused Railway)
Contra Costa County Road 120 (Minor/Unclassified Road) crosses Martinez Subdivision (Disused Railway)

@boothym
Copy link
Contributor Author

boothym commented Feb 22, 2019

Whoops, seems like my examples got messed up - I had put the railway line name in angled brackets:
"Rail (name of railway line) crosses Foot Path (name of path)" or "Primary Road (ref) crosses Path (name)"

In your example it is currently Contra Costa County Road 120 crosses Concord Subdivision. I think a new/casual mapper seeing this might be confused about what this means without the road/rail.

The other reason I suggested this is because you could have the exact opposite problem, where your issue message is too short. For example two features which don't have a name but have a ref, e.g. "A1 crosses M2" and be confused about what exactly the problem is, or what it is referring to?

jguthrie100 pushed a commit to jguthrie100/iD that referenced this issue Feb 24, 2019
@bhousel
Copy link
Member

bhousel commented Mar 8, 2019

Lets close this.. Since clicking on the message takes you to the issue, and hovering the message will highlight the things, the user can clearly see what kind of features they are by looking, and doesn't need any extra guidance in the message.

@bhousel bhousel closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants