Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Dykes should not need to be closed #5933

Closed
woodpeck opened this issue Feb 22, 2019 · 3 comments
Closed

Validation: Dykes should not need to be closed #5933

woodpeck opened this issue Feb 22, 2019 · 3 comments
Assignees
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Milestone

Comments

@woodpeck
Copy link

Copying this from the "tagging" mailing list:

On 22.02.19 12:46, Ulrich Lamm wrote:

Hi friends,

if you map a dyke, ID-editor recently gives a warning that a dyke ought to be a closed (circular) line.
On lowland coasts such as in Germany, this demand is a nonsense.
Some dyke lines (especially on the North Sea) have a length of several hundreds of kilometers. Nobody can map them in one session.
Other coasts, such as on the Baltic Sea, but also in England, have very low sections, that are protected by dykes, and hilly sections that do not require dykes.
There the dykes end at slopes of natural hills – which are not mapped, unless they are prominent escarpments.

Ulrich Lamm

@quincylvania
Copy link
Collaborator

I assume they're using man_made=dyke? The updated "area as line" check uses the preset data. Since we don't have a Dyke preset, iD falls back to the generic Man Made preset which should allow lines. Looks like a bug.

screen shot 2019-02-22 at 10 23 58 am

@quincylvania quincylvania added bug A bug - let's fix this! validation An issue with the validation or Q/A code labels Feb 22, 2019
@quincylvania quincylvania self-assigned this Feb 25, 2019
@quincylvania quincylvania added this to the Next Release milestone Feb 25, 2019
quincylvania added a commit that referenced this issue Feb 25, 2019
@woodpeck
Copy link
Author

Thank you for looking into this and fixing it. I have relayed the good news back to the tagging mailing list.

@quincylvania
Copy link
Collaborator

@woodpeck Happy to help! Thanks for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

2 participants