Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkbox for "flood_prone" key to "moreFields" of minor roads #6117

Closed
quincylvania opened this issue Mar 27, 2019 · 3 comments
Closed

Add checkbox for "flood_prone" key to "moreFields" of minor roads #6117

quincylvania opened this issue Mar 27, 2019 · 3 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Milestone
2.15.0

Comments

@quincylvania
Copy link
Collaborator

https://wiki.openstreetmap.org/wiki/Key:flood_prone
@quincylvania quincylvania added good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag labels Mar 27, 2019
@prateeklal
Copy link
Contributor

Could you please share a rough mockup of where this should be added?

@quincylvania
Copy link
Collaborator Author

quincylvania commented Mar 27, 2019 •
edited
Loading

The documentation for adding fields to presets is here. Basically you would need to add a flood_prone.json file under fields that is a check type for the flood_prone key. Then add flood_prone to moreFields of some of files like presets/highway/service.json, presets/highway/track.json, and presets/highway/residential.json.

Then run npm start, check that the field was properly added for those features, commit your changes (including the derived data) to a new branch, and open a PR!

prateeklal added a commit to prateeklal/iD that referenced this issue Mar 27, 2019
@prateeklal
Added checkbox for flood_prone key openstreetmap#6117
ee20d57
quincylvania added a commit that referenced this issue Mar 27, 2019
@quincylvania
Merge pull request #6120 from prateeklal/flood-prone
bf31d86 
Added checkbox for flood_prone key #6117
@quincylvania
Copy link
Collaborator Author

Done in #6120

@quincylvania quincylvania added this to the 2.15.0 milestone Mar 27, 2019
@bhousel bhousel mentioned this issue May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
2 participants
@quincylvania @prateeklal