Add presets for bicycle parkings... #6259
Conversation
... that are not essentially just a type of bicycle stands
|
I wonder, if this also changes the meaning of the regular "Bicycle parking" preset to be meant for "on street without cover". If so, the cover=no could be the smart default there (to be changed by users if required). |
|
No, because there are also normal stands which simply have a roof/cover but are open to the sides. In my area, often found at train and metro stations.
There is a StreetComplete quest that asks for bicycle stands if they are covered or not.
So, it is definitely a possible field for bicycle stands, but not automatically "no".
Am 29. April 2019 07:34:32 MESZ schrieb Tobias <notifications@github.com>:
…I wonder, if this also changes the meaning of the regular "Bicycle
parking" preset to be meant for "on street without cover". If so, the
cover=no could be the smart default there (to be changed by users if
required).
|
| ], | ||
| "tags": { | ||
| "amenity": "bicycle_parking", | ||
| "bicycle_parking": "building" |
There was a problem hiding this comment.
hmm this one is weird..
Is it really bicycle_parking=building and not building=bicycle_parking?
Can we change that before it gains traction?
There was a problem hiding this comment.
These are two different things:
bicycle_parking=building defines the type of bicycle parking: That it is in an enclosed building.
building=bicycle_parking is not defined in the wiki, but I guess it would be a building that was built for the purpose of serving as a bicycle parking station.
The difference is, that the bicycle parking doesn't have to fill the whole building but may be some area or point within the building. So, much like parking=multi-storey vs building=parking.
The bicycle_parking=building is already used by StreetComplete by a year or so. And much longer documented like that.
There was a problem hiding this comment.
I agree with Bryan, this preset is confusing. I'd prefer to just use indoor=yes and reserve the bicycle_parking tag for the actual method, like stands, lockers, or whatnot.
There was a problem hiding this comment.
indoor is for indoor-mapping only but bicycle_parking=building may and is often tagged on the whole building (but doesn't have to, as mentioned).
There was a problem hiding this comment.
On the wiki page, someone else raised a similar concern in 2017 as Bryan: https://wiki.openstreetmap.org/wiki/Talk:Key:bicycle_parking#Not_sure_if_bicycle_parking.3Dbuilding_makes_sense
There was a problem hiding this comment.
To summarize, tagging bicycle parking stations as bicycle_parking=building is missing an alternative because it could be tagged as an indoor-node but also the building itself. I see three options, please choose:
- drop the bicycle parking station preset from this PR
- limit the bicycle parking station preset to only areas and set
building=bicycle_parkinginstead - use
bicycle_parking=buildingafter all, leave PR as-is
There was a problem hiding this comment.
Hmm I was assuming this preset was for bike parking inside buildings with other purposes, but I guess bike parking garages are a thing? If that's what this tag is actually for, then I'm fine with option 2 as long as we rename the preset to "Bicycle Parking Garage" or similar.
There was a problem hiding this comment.
Yes, the Netherlands are known worldwide for their advanced bicycle infrastructure. They call these apparently mostly "fietsenstalling stationsplein" (literally: bicycle storage station square).
Here is a Google StreetView of such a location (note that bicycle "street" ). The same location in OpenStreetMap is already tagged.
Though, note that with option 2, the preset would not work for cases like these because it is mapped as a node, much like a amenity=parking_entrance.
I will probably have time to change the PR to option 2 later this evening (UTC+2) or otherwise on Saturday.
building=shed should not be added if the geometry is a point, but should, if possible, if it is an area. Unfortunately, the iD preset system is currently not able to map this behavior to a preset. Instead, there is the building_area field which automatically adds building=yes to the preset if it is an area.
|
Wait, I did not change anything yet! |
|
@westnordost I know! I figured I'd just take care of it so the translators can get started. |
|
Ok cool |
Add derived data for prior merge
... that are not essentially just a type of bicycle stands but a different thing (by name). See https://wiki.openstreetmap.org/wiki/Key:bicycle_parking