Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets for bicycle parkings... #6259

Merged
merged 3 commits into from
May 3, 2019
Merged

Add presets for bicycle parkings... #6259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff4043a
Add presets for bicycle parkings...
westnordost Apr 28, 2019
92c438a
capitalize names
westnordost Apr 28, 2019
0656cef
remove building=shed from bicycle_parking=shed preset
westnordost Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions data/presets/presets/amenity/bicycle_parking/building.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"icon": "maki-bicycle",
"fields": [
"{amenity/bicycle_parking}",
"opening_hours"
],
"geometry": [
"point",
"vertex",
"area"
],
"tags": {
"amenity": "bicycle_parking",
"bicycle_parking": "building"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this one is weird..
Is it really bicycle_parking=building and not building=bicycle_parking?
Can we change that before it gains traction?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are two different things:

bicycle_parking=building defines the type of bicycle parking: That it is in an enclosed building.

building=bicycle_parking is not defined in the wiki, but I guess it would be a building that was built for the purpose of serving as a bicycle parking station.

The difference is, that the bicycle parking doesn't have to fill the whole building but may be some area or point within the building. So, much like parking=multi-storey vs building=parking.

The bicycle_parking=building is already used by StreetComplete by a year or so. And much longer documented like that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Bryan, this preset is confusing. I'd prefer to just use indoor=yes and reserve the bicycle_parking tag for the actual method, like stands, lockers, or whatnot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indoor is for indoor-mapping only but bicycle_parking=building may and is often tagged on the whole building (but doesn't have to, as mentioned).

Copy link
Contributor Author

@westnordost westnordost May 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the wiki page, someone else raised a similar concern in 2017 as Bryan: https://wiki.openstreetmap.org/wiki/Talk:Key:bicycle_parking#Not_sure_if_bicycle_parking.3Dbuilding_makes_sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To summarize, tagging bicycle parking stations as bicycle_parking=building is missing an alternative because it could be tagged as an indoor-node but also the building itself. I see three options, please choose:

  1. drop the bicycle parking station preset from this PR
  2. limit the bicycle parking station preset to only areas and set building=bicycle_parking instead
  3. use bicycle_parking=building after all, leave PR as-is

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I was assuming this preset was for bike parking inside buildings with other purposes, but I guess bike parking garages are a thing? If that's what this tag is actually for, then I'm fine with option 2 as long as we rename the preset to "Bicycle Parking Garage" or similar.

Copy link
Contributor Author

@westnordost westnordost May 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the Netherlands are known worldwide for their advanced bicycle infrastructure. They call these apparently mostly "fietsenstalling stationsplein" (literally: bicycle storage station square).

Here is a Google StreetView of such a location (note that bicycle "street" ). The same location in OpenStreetMap is already tagged.
Though, note that with option 2, the preset would not work for cases like these because it is mapped as a node, much like a amenity=parking_entrance.

I will probably have time to change the PR to option 2 later this evening (UTC+2) or otherwise on Saturday.

},
"reference": {
"key": "bicycle_parking"
},
"terms": [
"Multi-Storey Bicycle Park",
"Multi-Storey Bike Park",
"Bike Parking Station"
],
"name": "Bicycle Parking Station"
}
19 changes: 19 additions & 0 deletions data/presets/presets/amenity/bicycle_parking/lockers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"icon": "maki-bicycle",
"geometry": [
"point",
"vertex",
"area"
],
"tags": {
"amenity": "bicycle_parking",
"bicycle_parking": "lockers"
},
"reference": {
"key": "bicycle_parking"
},
"terms": [
"Bike Lockers"
],
"name": "Bicycle Lockers"
}
23 changes: 23 additions & 0 deletions data/presets/presets/amenity/bicycle_parking/shed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"icon": "maki-bicycle",
"fields": [
"{amenity/bicycle_parking}",
"building_area"
],
"geometry": [
"point",
"vertex",
"area"
],
"tags": {
"amenity": "bicycle_parking",
"bicycle_parking": "shed"
},
"reference": {
"key": "bicycle_parking"
},
"terms": [
"Bike Shed"
],
"name": "Bicycle Shed"
}