Pipeline valve preset

[flacombe]

Hello

Currently, iD shows no particular preset for pipeline valves despite some can be seen on ground.
https://www.openstreetmap.org/node/6448156547

See https://wiki.openstreetmap.org/wiki/Tag:pipeline=valve
At least valve, location, operator, actuator and handle should be available.

You'll find a simple icon I've designed (CC BY-SA-NC) which corresponds to any valve with handle (actuator or handle+actuator) are also available
vanne_handle.zip

Thanks in advance to take care of this issue.

[bhousel]

Sounds like a good suggestion, thanks!

I'll probably just redraw the icon - I only really use public domain icons in the project for simplicity.
(also FontAwesome, which is CC-BY-SA but we credit them in a few places).

[flacombe]

Ok no problem, you can redraw it.
Mine doesn't follow ususal iD design guidelines anyway.

[quincylvania]

I went ahead and added this without an icon. We can add the icon as soon as we find or draw a suitable one.

[flacombe]

Hi

On iD 2.15.4, a node with pipeline=valve won't get any preset despite commit b2d406d
Is there any additional action to do for that?

[quincylvania]

@flacombe To match the preset, the feature must also:

• Have man_made=pipeline
• Be part of a way (presumably a pipeline)

[flacombe]

Have man_made=pipeline

This is where I got lost
pipeline=valve doesn't expect man_made=pipeline, because man_made=pipeline is on the way the valve should be member of.
https://wiki.openstreetmap.org/wiki/Tag:pipeline%3Dvalve

[quincylvania]

iD is following the advice of the wiki here. This makes sense since pipeline isn't a top-level key.

See https://wiki.openstreetmap.org/wiki/Key:pipeline:

See also: man_made=pipeline

Tags within this key further describe features on or related to pipelines.

[flacombe]

Indeed, that's right... and probably a mistake due to dataitems bot edits.
Last bot dance add P22 property with man_made=pipeline without any justification.
https://wiki.openstreetmap.org/w/index.php?title=Item%3AQ4978&type=revision&diff=1832281&oldid=1783550

I've edited the item to remove it, valves never expect man_made=pipeline, this was never proposed nor reviewed, sorry for mistake and noise.

[flacombe]

Hi all

I confirm that man_made=pipeline isn't required on pipeline=valve objects.
Could you consider updating the preset in id please?

[quincylvania]

I confirm that man_made=pipeline isn't required on pipeline=valve objects.
Could you consider updating the preset in id please?

@flacombe Okay, I did this. I'm not sure I like how pipeline is used as a top-level tag but if this is the OSM tagging then iD will support that ✌️

[flacombe]

Thanks

This is indeed reviewed tagging
Pipeline is "top level" key for valves, surge tanks, substations and proposed for disusage marker. There will be a proposal for pumps as well.
This is just like power or waterways IMHO.