Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunkers + landuse? #6509

Closed
Hjart opened this issue Jun 8, 2019 · 9 comments · Fixed by #6518
Closed

Bunkers + landuse? #6509

Hjart opened this issue Jun 8, 2019 · 9 comments · Fixed by #6518
Labels
preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@Hjart
Copy link

Hjart commented Jun 8, 2019

Why does iD want to tag bunkers (like i.e. https://www.openstreetmap.org/way/531205744) landuse=military? Adding building=bunker in most cases would be ok, provided that it's actually overground, but landuse=military, I consider a clear mistake.

@bhousel
Copy link
Member

bhousel commented Jun 8, 2019

Because the landuse=military page says to dual tag them.
https://wiki.openstreetmap.org/wiki/Tag:landuse%3Dmilitary

@kymckay
Copy link
Collaborator

kymckay commented Jun 8, 2019

Initially reading this I thought it sounded wrong too. However after seeing the wiki it doesn't seem like an iD issue - more of a general tagging consensus issue (for what it's worth, it seems silly to me too). Perhaps take it up with the tagging list?

@Hjart
Copy link
Author

Hjart commented Jun 8, 2019

I guess it's a mistake that this is in the wiki at all, more than a "general tagging consensus issue". I don't think many will agree with it being in there. It was added in https://wiki.openstreetmap.org/w/index.php?title=Tag%3Alanduse%3Dmilitary&type=revision&diff=1312820&oldid=1304889 and I'll remove it unless there are objections to it : https://wiki.openstreetmap.org/wiki/Talk:Tag:landuse%3Dmilitary

@matkoniecz
Copy link
Contributor

matkoniecz commented Jun 8, 2019

Because the landuse=military page says to dual tag them.

I would interpret this page as "landuse=military may have this tags", not "this tags must have landuse=military". Still, typically military=bunker would be anyway within landuse, not have landuse tagged on it.

For example see German-build bunkers in occupied Poland that nowadays are tourism attraction/abandoned/memorial sites and not used by military. landuse=military for them would be incorrect. Like for example https://en.wikipedia.org/wiki/Wolf%27s_Lair


Wiki edited in https://wiki.openstreetmap.org/w/index.php?title=Tag:landuse%3Dmilitary&diff=1859444&oldid=1567545 (further improvements are welcomed)

@Hjart
Copy link
Author

Hjart commented Jun 9, 2019

We have tons of abandoned german WW2 (and some WW1) bunkers just sitting around in Denmark too (see i.e. https://commons.wikimedia.org/wiki/Category:Atlantic_Wall_in_Denmark). The vast majority are not in any kind of military area and many are freely accesible to the public. I can't even find any situation in which tagging a bunker landuse=military would be correct.

@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label Jun 10, 2019
@bhousel
Copy link
Member

bhousel commented Jun 10, 2019

see also #3663 where I wrote:

I think maybe the wiki should be fixed if it is suggesting to put a landuse=military tag on every military feature.

@matkoniecz
Copy link
Contributor

It seems a wider problem, multiple features defined /data/presets/presets/landuse/military may need to be modified.

I think maybe the wiki should be fixed if it is suggesting to put a landuse=military tag on every military feature.

Is there a wiki page where it is still suggested?

@bhousel
Copy link
Member

bhousel commented Jun 10, 2019

Is there a wiki page where it is still suggested?

yes, the landuse=military page (that you just edited) still says to do it.
https://wiki.openstreetmap.org/wiki/Tag:landuse%3Dmilitary

Screenshot 2019-06-10 15 18 18

@matkoniecz
Copy link
Contributor

matkoniecz commented Jun 10, 2019

I added explicit note that military=* is not always added

== How to map? ==
Map an outline of the military area {{IconArea}} and add
* {{tag|landuse|military}}

In case where it is applicable add also {{tag|military}}.

Note that in many cases {{tag|military}} objects are mapped separately,
for example {{tag|military|bunker}} that may be within
{{tag|landuse|military}} or outside it (common for historic bunkers)

EDIT: PR with fix is now opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants