Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names with brands and qualifiers are not offered brand tags #6561

Open
crimsondusk opened this issue Jun 21, 2019 · 0 comments
Open

Names with brands and qualifiers are not offered brand tags #6561

crimsondusk opened this issue Jun 21, 2019 · 0 comments
Labels
validation An issue with the validation or Q/A code

Comments

@crimsondusk
Copy link

In Finland it is standard practice to include a location qualifier after a brand in the name. So the shop has its own name even though it is part of a chain. iD does not seem to support this case out of the box:

Consider, for instance, this supermarket.
Its tags are:

building=yes
name=K-supermarket Hirvensalo
shop=supermarket

"K-supermarket" (the 's' should be capitalized) is the brand and "Hirvensalo" is the island it is located in. iD does not figure out that it is missing brand tagging before I remove "Hirvensalo" from the name. iD also offers to fix the name.

Skärmbild 2019-06-21 12:44:42

After the tags are updated, the name field is locked, so I have to manually fix the name tag from the tags table:
Skärmbild 2019-06-21 12:45:25

So while it's possible to add brand tags to shops like this, it could be more convenient. In my opinion, iD should understand that the brand can be followed by qualifiers and these qualifiers should be retained after any changes to the brand name in the name tag. The name field also should not be locked like this because it might change.

@crimsondusk crimsondusk changed the title Names with brands and qualifiers could be handled better Names with brands and qualifiers are not offered brand tags Jun 21, 2019
@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

2 participants