-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sub-brands in DE, AT and CH for nextbike #3381
Conversation
We do need |
Do we really need a |
This particular index currently needs one |
At some point we will probably support other tags like |
@sb12, It's not like people can't just edit the name field if need be. It's currently that way with other things in the index that have local names along with the more general name, like post offices or hotels. Given that would you be willing to just add the name tags so this can be merge? Because it's better to have the presets then not. Especially with the Nextbike preset being removed in #3378. Which, IMO and how you made it sound there, was semi-contingent on this PR happening. |
In theory yes, in praxis I might add the @bhousel: Travis also complains about |
I think if you're not happy about it, we should just leave it out of the index for now. For now the index is really designed around brands with consistently named features. It is after all called the "name suggestion index", and we are seeding it with the data that we find in the We know that we do have a handful of things in the index with name variability (for example, hotels and car dealerships) but in those cases it's not the worst thing if a mapper adds a dealership with the name "Honda", and then forgets to rename it to "Planet Honda Route 22".
Until people are happy with how iD and NSI are working together, we don't have to try to stick everything into the NSI that doesn't really fit. Here are some related tickets |
Well, I'm disappointed. I totally understand where your coming from though. @sb12 could you at least discuss this on the German tagging mailing list before we completely leave it like out (like you should have done before requesting NextBike's removal)? |
@ENT8R, your from Germany right? Do you have any opinions on this? |
Actually I fully agree with @bhousel. Currently this type of data does not really fit to the goals of the index, maybe in the future there will be another chance to add this. Maybe we need an network-suggestion-index beside this index... 😄 |
That's how it originally was, but unfortunately it got removed because of #3378. I guess it can be re-added though. That's what should happen IMO. |
I think I'm going to close this since the consensus seems to be that it doesn't fit with the index. Maybe someone can add the Nextbike entry back at some point if that's what the community wants so there's at least something related to in iD. If not though, that's fine also. |
See #3378