Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit menu on touch devices #7577

Closed
quincylvania opened this issue May 8, 2020 · 1 comment
Closed

Edit menu on touch devices #7577

quincylvania opened this issue May 8, 2020 · 1 comment
Assignees
@quincylvania
Labels
touch-stylus An issue with touchscreen or pen input
Milestone
2.18.0

Comments

@quincylvania
Copy link
Collaborator

With #5505 coming along, touchscreen mapping is becoming increasingly possible. A large remaining issue, though, is the lack of right-click and thus the map edit menu.

iOS has a pattern of long-pressing on text to bring up contextual controls. Perhaps we could try a similar interaction here.
@quincylvania quincylvania added the touch-stylus An issue with touchscreen or pen input label May 8, 2020
@quincylvania quincylvania self-assigned this May 8, 2020
@quincylvania quincylvania added this to the 2.18.0 milestone May 9, 2020
quincylvania added a commit that referenced this issue May 10, 2020
@quincylvania
Fix menu position when long-pressing features on touchscreens (re: #7577
e6fc7e2 
)

Improve comment
@quincylvania quincylvania mentioned this issue May 10, 2020
Closed
@quincylvania
Copy link
Collaborator Author

iOS has a pattern of long-pressing on text to bring up contextual controls. Perhaps we could try a similar interaction here.

I did this ☝️. It felt pretty natural in my brief testing. We'll have to do #7590 and adapt some of the operations like Move and Rotate in order to achieve full parity, but this is still an exciting step forward.

ezgif-4-d3dec5f8b6ba

quincylvania added a commit that referenced this issue May 12, 2020
@quincylvania
Position the edit menu above the anchor point if triggered via touch …
23714ba 
…or stylus (re: #7577)

Add additional code safety to behaivorSelect
@quincylvania quincylvania mentioned this issue May 13, 2020
Closed
quincylvania added a commit that referenced this issue May 14, 2020
@quincylvania
Allow selection, deselection, and multiselection with the spacebar (re:
dff4268 
#3843)

Don't open the edit menu on single spacebar press
Open the edit menu for long spacebar press (re: #7577)
@quincylvania quincylvania mentioned this issue May 14, 2020
Closed
@quincylvania quincylvania mentioned this issue May 29, 2020
Open
quincylvania added a commit that referenced this issue Jun 26, 2020
@quincylvania
Show labels for edit menu items on touch interaction (re: #7577)
5e58259
quincylvania added a commit that referenced this issue Jun 27, 2020
@quincylvania
Be smarter about positioning the labeled edit menu (re: #7577)
c60dcba
@quincylvania quincylvania mentioned this issue Jul 20, 2020
Merged
@tyrasd tyrasd mentioned this issue Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
touch-stylus An issue with touchscreen or pen input
Projects
None yet
Milestone
2.18.0
Development

No branches or pull requests
1 participant
@quincylvania