Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outstanding issues viewed are being counted towards ignored outstanding issues #8613

Closed
boxer4 opened this issue Aug 1, 2021 · 2 comments · Fixed by #8626
Closed

outstanding issues viewed are being counted towards ignored outstanding issues #8613

boxer4 opened this issue Aug 1, 2021 · 2 comments · Fixed by #8626
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@boxer4
Copy link

boxer4 commented Aug 1, 2021

With the recent iD update on live, it seems that it's all around easier to trigger an ignored outstanding issue, even if the user did not touch a feature, perhaps even just viewing (sometimes not even clicking on) a feature that has some issue in iD seems to now be sufficient to trigger the warning which gets tracked with the check-in. Recently I've been touching turn restriction relations (without touching ways) and iD decides to include me as ignoring bus route warnings. These are unrelated features/relations as I didn't split ways, etc., and perhaps this issue is the same as the FIXME issue #8603 .

This "ignored warning" count that gets tagged with each check-in seems quite silly and also untenable. For those people doing user metrics, perhaps it's just HDYC, this number will become ridiculously large and impossible to reduce to zero. For each warning ignored, everyone ignores them, and keeps on going up. Every time we fix an error whether in iD or not, only ONE person is credited for fixing an error (and it could even be fixed in another editor) and the ignored warning count becomes an ever increasing, meaningless number. These warning/issues are already being checked with OSMI, KeepRight, Osmose, etc. and these at least will clear credits for everyone when something gets fixed. Is there any specific reason a problem warning ignored in iD needs to be tracked but not through JOSM/Potlatch/Merkaartor/or any other editor? Suggestion is to stop including this count with the checkins. In my opinion the QA should be done at the check-in server so it doesn't matter which editor software is used, not any specific editor software.

Just my observation/opinion/rant/2 cents/...

@boxer4 boxer4 changed the title outstanding Issues not made, just viewed, are being counted towards outstanding issues outstanding issues viewed are being counted towards ignored outstanding issues Aug 1, 2021
@mbrzakovic
Copy link
Collaborator

@boxer4 thanks for raising this.
I acknowledge the issue and will try to pinpoint the bug.

@mbrzakovic mbrzakovic added the validation An issue with the validation or Q/A code label Aug 2, 2021
@mbrzakovic mbrzakovic added this to the 2.20.1 milestone Aug 2, 2021
@mbrzakovic mbrzakovic self-assigned this Aug 2, 2021
@bhousel
Copy link
Member

bhousel commented Aug 2, 2021

I'm looking into this already - it's probably things I did around 11201eb

@mbrzakovic mbrzakovic assigned bhousel and unassigned mbrzakovic Aug 2, 2021
bhousel added a commit that referenced this issue Aug 5, 2021
The previous code was grabbing _all_ parent relations, which is too much.
For example: if a user changed a road, the validator was treating it like
the user had changed bus and highway routes along that road.

(closes #8613)
(helps a lot #8612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants