Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some field values missing formatting #8629

Closed
boothym opened this issue Aug 6, 2021 · 8 comments
Closed

Some field values missing formatting #8629

boothym opened this issue Aug 6, 2021 · 8 comments

Comments

@boothym
Copy link
Contributor

boothym commented Aug 6, 2021

Seems to have occurred since 2.2.0.

In the screenshot it happens in the surface field, however I've seen it in other field as well.

id220

@1ec5
Copy link
Collaborator

1ec5 commented Aug 7, 2021

The values shown in blue, variable-spaced font and title-cased are the ones explicitly listed for translation, although translations aren’t getting pulled in yet: #8600. The monospaced font is intended to emphasize that the other values are raw values that haven’t been manually curated but were instead pulled in from taginfo based on frequency in the database.

https://github.com/openstreetmap/id-tagging-schema/blob/e8d86eb0bdbad8e466a6e06a62899f422440175a/data/fields/surface.json#L6-L19

@boothym
Copy link
Contributor Author

boothym commented Aug 9, 2021

@mbrzakovic have you closed this issue because it has been or will be fixed?

Because I also noticed the opening hours field with a monospaced font for its text.

@1ec5
Copy link
Collaborator

1ec5 commented Aug 9, 2021

That’s intentional: the Opening Hours field accepts a raw value rather than a translatable one. The use of monospaced font in fields is new in v2.20.0.

@mbrzakovic
Copy link
Collaborator

1ec5 gave correct explanation. Shortly: What you are seeing is a feature, not an issue.

@boothym
Copy link
Contributor Author

boothym commented Aug 11, 2021

Hmm. What's the need for this feature? Does an end user need to know whether a value is translatable or not?

In other fields like buildings the monospaced font is used for the entire set of values in the dropdown. Was this change to add worse looking text discussed anywhere on here?

@mbrzakovic
Copy link
Collaborator

Sorry for not providing more context earlier. Please take a look at following: #8238, #2708

@boothym
Copy link
Contributor Author

boothym commented Aug 11, 2021

Thanks - my next question is where can people contribute to these translations and is it publicised anywhere so that users who see the monospaced font can go and help with the translations? 😉

@mbrzakovic
Copy link
Collaborator

https://github.com/openstreetmap/iD/blob/develop/CONTRIBUTING.md#translating. What should be of interest to you is 'Presets' translations that would be pulled in https://github.com/openstreetmap/id-tagging-schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants