Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repost: Support translatable options in all combo fields #8238

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

quincylvania
Copy link
Collaborator

Closes #2708.

This is essentially a re-implementation of #7411, but on top of the unbundled preset system. I'll just repost what I wrote before:

This extends iD's existing mechanism for translating combo field options to support fields where all possible values may not be predetermined. The text styling indicates which values are raw tags and which are translated labels. It works for semiCombo and multiCombo as well as single-value combos. Multiselection is also supported.

This functionality opens the door to adding loads of new tagging data to the presets, which is the main reason I've held off on the change up until now. But the new, robust preset system should help alleviate headaches in a few ways:

  • There's a focused repo for people to collaborate and debate changes
  • We can now make tweaks without having to ship iD itself
  • 100% translation completion on preset strings is now distinct from 100% completion on iD's other strings

Translation is a major factor here. I know people have been translating tags in the OSM Wikibase for awhile now, so we should see if there's a good way to avoid duplicate work.

Add UI for translatable combo fields
@matkoniecz
Copy link
Contributor

I know people have been translating tags in the OSM Wikibase for awhile now

Interesting - I am not a fan of data items, but this is a case where they can be useful.

@quincylvania quincylvania self-assigned this Dec 9, 2020
@quincylvania quincylvania added this to the 2.20.0 milestone Dec 9, 2020
@manfredbrandl
Copy link
Contributor

Question: After this PR goes live will the translations for presets be used from the OSM-Wiki instead of Transifex?

@quincylvania
Copy link
Collaborator Author

Question: After this PR goes live will the translations for presets be used from the OSM-Wiki instead of Transifex?

@manfredbrandl No, but something like this might be future work.

Make custom combo field values lowercase if they're also made snake_case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openstreetmap tag strings are not translatable
3 participants