Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KartaView name not updated #8807

Closed
martino2002 opened this issue Nov 13, 2021 · 7 comments
Closed

KartaView name not updated #8807

martino2002 opened this issue Nov 13, 2021 · 7 comments
Labels
chore Improvements to the iD development experience or codebase

Comments

@martino2002
Copy link

URL

No response

How to reproduce the issue?

I know this isn't a bug but this GitHub doesn't give enough options to select type of issue.
KartaView is still referred to as OpenStreetCam in <Map Data<Photo Overlays.

Screenshot(s) or anything else?

No response

Which iD Editor versions do you see the issue on?

Released version at openstreetmap.org/edit

Which browsers are you seeing this problem on?

Chrome

@1ec5
Copy link
Collaborator

1ec5 commented Nov 13, 2021

Looks like these strings need to be updated (and their translations):

iD/data/core.yaml

Lines 1408 to 1412 in 5f58b53

openstreetcam_images:
tooltip: "Street-level photos from OpenStreetCam"
openstreetcam:
title: OpenStreetCam
view_on_openstreetcam: "View this image on OpenStreetCam"

@matkoniecz
Copy link
Contributor

not sure is it desirable to rename also string names

matkoniecz added a commit to matkoniecz/iD that referenced this issue Nov 14, 2021
not sure is it desirable to rename also string names

fixes openstreetmap#8807 if string names should not be renamed
@martino2002
Copy link
Author

not sure is it desirable to rename also string names

Why not? I'm no expert.

@tyrasd tyrasd closed this as completed in 25d4ff1 Nov 16, 2021
@tyrasd tyrasd added the chore Improvements to the iD development experience or codebase label Nov 16, 2021
@tyrasd
Copy link
Member

tyrasd commented Nov 16, 2021

not sure is it desirable to rename also string names

I've renamed also the internal modules/variables/css-classes/etc. 🙈

Everything should still work as before, but a little double testing on the develop instance at https://ideditor.netlify.app would be very much appreciated.


I know this isn't a bug but this GitHub doesn't give enough options to select type of issue.

off topic, but there is an option to open a blank ticket. It's quite well hidden, though 🙈

@1ec5
Copy link
Collaborator

1ec5 commented Nov 16, 2021

I’m getting an SSL_ERROR_BAD_CERT_DOMAIN error in Firefox 94 when attempting to access https://www.kartaview.org/:

iD/data/core.yaml

Line 1612 in c854564

intro: "Street level photos are useful for mapping traffic signs, businesses, and other details that you can't see from satellite and aerial images. The iD editor supports street level photos from [Bing Streetside](https://www.microsoft.com/en-us/maps/streetside), [Mapillary](https://www.mapillary.com), and [KartaView](https://www.kartaview.org)."

The www.kartaview.org domain still has an SSL certificate restricted to OpenStreetCam branding:

openstreetcam.org, api.openstreetcam.org, dashboard.openstreetcam.org, internal.openstreetcam.org, www.openstreetcam.org

https://kartaview.org/ appears to be unaffected.

1ec5 added a commit that referenced this issue Nov 16, 2021
@1ec5
Copy link
Collaborator

1ec5 commented Nov 16, 2021

e2a5345 replaces www.kartaview.org with kartaview.org.

@tyrasd
Copy link
Member

tyrasd commented Nov 17, 2021

thanks for the fix @1ec5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements to the iD development experience or codebase
Projects
None yet
Development

No branches or pull requests

4 participants