-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show relation/member IDs somehow #9349
Comments
I usually rely on the highlighted map features to distinguish the relations/members in such cases: when you hover over the corresponding relation (or member), the map view will show the respective elements in a blue highlight (in addition to the yellow highlight for the currently selected feature). At the moment, iD does (by design) not visually expose the OSM element ids anywhere. I'm not sure what real benefit showing the id would bring, except maybe to be able to distinguish situations like where two members have the same title vs. when an element is member of a relation twice. May I ask you to elaborate a bit further how displaying the id would help in your use case?
Oh… currently, the "backward" button is not actually a "backward" button, but rather a secondary way to get to into the preset selection mode. The hover text of the button was just wrong there – that's fixed now in 78d37fd. I guess having a proper history of selected elements with real forward/backward buttons could indeed be useful for these situations. 🤔 |
iD does display the selected element’s ID in the History and Measurement panels, but these panels are rather out of the way and don’t apply to a feature that you’re just hovering over. Also, relation IDs do appear when selecting a relation from a list if a relation is unlabeled or if two relations have the same label. However, this text isn’t selectable. Maybe it’s finally time to add a context menu to (that part of) the inspector? 😬
|
Alas, that doesn't work in most cases. A superrelation will by definition include the same ways as a child relation; it is impossible to tell using just this mechanism which one to add to. Also, a hiking route relation and a bicycle route relation will often share the same name and some of the same ways - you have to combine the geographical information from "mouse hover" with iD's interpretation of relation tags (in those cases where it understands them. Somewhat related to #9942 . |
When you go to add a feature to a relation, the dropdown list does disambiguate identically labeled relations by their IDs. Here’s what it looks like if I create two However, the disambiguation doesn’t show up when listing the existing memberships. This would be a nice improvement. By design, the IDs also don’t show up if the two relations already have different labels: A Incidentally, #8276 tries to make the labels differ in more cases by appending directions and destinations to the label. Unfortunately, this gets unwieldy quickly, especially when the sidebar is narrow. It also fails when the two relations have basically the same tags. Ideally, the relation list would hide the extra details unless two or more relations would get the same label, then progressively show the extra details, just like it does with relation IDs. I wanted to do this for #8276 but was unable to figure out an elegant way to work that into the existing call hierarchy. It might become more important with an implementation of #9026. |
Is there any way to get from the numbers shown there to an OSM browse page that let's you see the difference between the two relations? I've just hit this again with https://www.openstreetmap.org/relation/1761919 , https://www.openstreetmap.org/relation/11328997 and https://www.openstreetmap.org/relation/10521621 . Is it possible to click on the name somehow to open an OSM browse page (usually called "View on openstreetmap.org") before selecting a relation? |
The links to the browse page in the inspector and in the History panel are only available once you select the relation. (This is also true of other element types, not specific to relations.) Are you describing a situation in which you’re inspecting a feature that’s already a member of these relations, or one in which you’re choosing a relation to add the feature to? If the former, it would be pretty nice if the blue label were an actual link to the browse page; iD would intercept clicks to select the relation as usual instead of opening anything. This would allow you to Ctrl/Command-click to open the relation browse page in a new tab. Other Web applications do this with permalinks to good effect. |
Both, actually. Here's the location: https://www.openstreetmap.org/#map=18/53.73240/-1.07252 . I was trying to see what was already added to what relation, and also decide which relation to add new ones to. |
For the new relation dropdown, it would also be nice to linkify each item. This would have the side effect of triggering your browser’s built-in URL status bar panel on hover. However, I vaguely recall that the control we’re using for these dropdowns doesn’t readily support embedded links at all. |
(continuing conversation from #10103 )
Actually, it would be great if it could do that at all times. iD doesn't know the context in which I am searching - it might be "is this relation number correct". Names may be similar, but not identical. Unless I can see the relation number, I can't be sure. The potential "labels already easily get cut off when the sidebar is at a reasonable width" issue could be solved by (optionally) showing the relation ID - the most important piece of information by far - at the start, not at the end.
Please no. JOSM does this, and it makes relation IDs significantly harder to understand based on a "glance" because the thing that I'm comparing them with (the OSM website) doesn't use digit grouping for them. |
I think most users would disagree with you about the relation ID being the most important piece of information by far. It certainly is for your use case, but not for the majority of edits that take place in this part of the UI. |
There is this list of members for a relation (and similar the list of relations for an element)
This allows us navigating to the corresponding elements by a simple click. However, it is hard to distinguish the different members (like the two u-turn relations here). My current workflow would be clicking on a member and then copying the 'View on openstreetmap.org' link to extract the ID, but that is rather cumbersome, especially because after clicking a member there is no way to go back to where I came from. Update: Ok this is possible by clicking the relation we came from in the list of the relations of the member we clicked at least. The 'backward' button opens a pane saying 'Select Feature Type' for some reason.
The text was updated successfully, but these errors were encountered: