Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panoramax streetlevel image data #9941

Closed
u4y0u opened this issue Oct 16, 2023 · 10 comments
Closed

Add panoramax streetlevel image data #9941

u4y0u opened this issue Oct 16, 2023 · 10 comments
Labels
streetlevel An issue with streetlevel photos

Comments

@u4y0u
Copy link

u4y0u commented Oct 16, 2023

Description

Hello, It would be interesting to plan now to integrate the street imagery of the panoramax instances ( osm , ign ...etc ) in the same way as that of Mapillary.
With, just like this one, the possibility of seeing the captured image by clicking on the point of the panoramax overlay (https://api.panoramax.xyz/...map/{z}/{x}/{y)}.pbf) and choose the direction of view in the thumbnail or click on a link to access high-resolution imagery .
Panoramax provides openstreetmap contributors with high resolution images which will greatly facilitate the enrichment of the OSM database if their integration into the ID editor is carried out.

Available on the meta catalog:
in the sequence
https://api.panoramax.xyz/#focus=pic&map=19.41/47.901861/1.9090413&pic=56ddb766-e929-4e86-b7ce-f5df894a6442&speed=250&xyz=73.77/4.88/30

in the url '... pic='... uuid of the image

the link is: https://api.panoramax.xyz/api/pictures/uuid/hd.jpg
like:
https://api.panoramax.xyz/api/pictures/56ddb766-e929-4e86-b7ce-f5df894a6442/hd.jpg
and then redirecting on the OSM instance...
https://panoramax.openstreetmap.fr/images/56/dd/b7/66/e929-4e86-b7ce-f5df894a6442.jpg

Screenshots

osm panoramax instance and GeoVisio viewer.
image

@thibaultmol
Copy link
Contributor

(Something that i've mentioned before somewhere os that I hope there will be some kind of system if the same image is on Mapillary and on GeoVisoo, that it doesn't display two dots on the map for the same image. But GeoVisio doesn't have a metadata field for matching Mapillary image key... Yet)

@tyrasd tyrasd added the streetlevel An issue with streetlevel photos label Oct 23, 2023
@tuxayo
Copy link

tuxayo commented Feb 18, 2024

But GeoVisio doesn't have a metadata field for matching Mapillary image key... Yet

How would that field be populated? In addition to that question, the same wish for such a field could be directed at Mapillary.

Regardless of that, to circumvent those problems, would it work to have ID on image load identify that two images have the same coords from different providers (accounting for an eventual rounding error) and then ignore one of the duplicates?

The last part of ignoring duplicates (and which provider keep when there is duplication) is the same if one image provider had a field to indicate the image is also in another base. So the difference is having duplication identification based on coordinates and not a field that one of the duplicates would have.

@brunnerpaul
Copy link

@thibaultmol, IMHO an image deduplication across different services falls into the "nice to have" category.
iD currently offers previews of 4 different services plus local images, my experience is I mostly have only 1 of them open at a time anyways.
Screenshot 2024-04-01 at 22 36 35

And generally, yes, it would be great to see imagery from the Panoramax instances in iD!

@thibaultmol
Copy link
Contributor

@tuxayo

How would that field be populated? In addition to that question, the same wish for such a field could be directed at Mapillary.

Not really, they're the 'market leader', they won't do that
There is a way to add the mapillary key on the EXIF data of the images on Panoramax

Regardless of that, to circumvent those problems, would it work to have ID on image load identify that two images have the same coords from different providers (accounting for an eventual rounding error) and then ignore one of the duplicates?

Same coordinates and same time, should be enough to identify images yeah


Also good to add to this issue, there is a Google Open Summer of Code project to add Panoramax viewing support to iD: https://wiki.openstreetmap.org/wiki/Google_Summer_of_Code/2024/Project_ideas#Support_display_of_images_from_Panoramax_in_iD

@pietervdvn
Copy link

Hi all,

With MapComplete, we are looking into Geovisio/Panoramax as well. @thibaultmol entered a proposal at NlNet for me.

For our usecase, we would like to:

  1. Query which pictures are around a certain point and display them
  2. Upload to a geovisio instance

It might be interesting to work together or to reuse your work. Ideally, if all the functionality would be packaged into TS-library, then we could just reuse all of this.

As such, I'm a bit wondering how the functionality would be implemented and if this kind of reuse would be possible.

@tordans
Copy link
Collaborator

tordans commented Apr 5, 2024

For our usecase, we would like to:

  1. Query which pictures are around a certain point and display them
  2. Upload to a geovisio instance

I don't think those features are something that iD does or expressed interested to do before. I understand this ticket to be focussed on just displaying all the images of all instances in a given viewport and allow to view them in a viewing panel. (Ideally with some kind of image-key interaction similar to #10046).

@pyrog
Copy link

pyrog commented Jun 9, 2024

  1. Query which pictures are around a certain point and display them

For a specific OSM object, application could query object id.
Not yet possible with Panoramax (but osm id could be stored in picture metadata).
FYI, this is possible with Wikimedia Commons (OSM Hydrant do this)

… or the application could display pictures (tagged with panoramax)

@tordans
Copy link
Collaborator

tordans commented Jun 27, 2024

For reference: According to WeeklyOSM 723 @mattiapezzotti is working on this feature over at https://github.com/mattiapezzotti/iD/tree/panoramax

Mattia Pezzotti, a Google Summer of Code 2024 participant, presented their project for integrating Panoramax imagery into the iD editor. The project aims to enhance map exploration by incorporating 360-degree imagery, providing users with valuable visual context and improving map visualisation and community engagement.

There is more info in Mattia's blog post.

@tordans
Copy link
Collaborator

tordans commented Jul 5, 2024

FYI the blogpost at https://www.openstreetmap.org/user/Juicio/diary/404174 receives weekly updates for the last 6 weeks on the project.

@tyrasd
Copy link
Member

tyrasd commented Jul 29, 2024

This was implemented in #10317 by @mattiapezzotti .

You can already test it on iD's preview instance https://ideditor.netlify.app (here's an example location with good coverage on Panoramax). Please test it and report issues that you might find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
streetlevel An issue with streetlevel photos
Projects
None yet
Development

No branches or pull requests

8 participants