New Panoramax StreetView Layer (GSOC) #10317
Merged
+1,229
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing to a different photo, it can be the case that the new photo has a different aspect ratio: the zoom behaviour needs to be updated. Also, keeping the "orientation" does not make sense for plane photos, and even keeping the previously shown photo's zoom is also not typically desired for these.
fix zoom/pan glitch on plane photos
|
You can set this PR as draft instead it is ready to be reviewed. Thanks for this contribution, can't wait to use it! |
Fixing a bug with heading
Fixing a bug with heading
mattiapezzotti
force-pushed
the
panoramax
branch
from
ae35a48 to
b0d9a2c
Compare
in panoramax a username can resolve to multiple ids (when the same name is used on multiple servers). further, the username filter input field can contain more than one username
tyrasd
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
@mattiapezzotti I've tested the implementation and found a few minor things that I fixed in my commits in this branch today:
- the date filters did not update immediately (this was also buggy in the mapilio layer, and likely was a simple copy-paste mistake)
- username filters: sometimes did not update when the input field was changed and did not take into account that a single user name can have more than one user id in panoramax (one per server, e.g. one for openstreetmap.fr and one for the IGN server)
- the username input field can supply more than one username
- this branch contained a bit of code (and translatable strings) which is only needed for the upcoming enhancement (date slider). I've removed it for now. You might have to pay attention to that when rebasing your other branch on the development branch after this PR is merged.
Apart from that, this seems to work quite well. Thank you!
|
Hi there, I am Puja Kumari currently planning to contribute to open source through GSOC and I found the OpenStreetMap community particularly inspiring because of its mission to create and provide free, accessible geographic data for the world. It would be really great if the community members would help me to know regarding how should I get started. Thanks and Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings a brand new StreetView Layer to Street Images as requested in #9941
This is still a wip, expect some bugs :P
//edit @tyrasd: For some screenshots and additional details, see https://www.openstreetmap.org/user/Juicio/diary/404174 and https://github.com/openstreetmap/iD/wiki/GSoC-2024-%E2%80%93-Panoramax-integration