Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tracestrack Localized Topo Universal imagery #10146

Closed
wants to merge 1 commit into from

Conversation

quinncnl
Copy link

@quinncnl quinncnl commented Mar 3, 2024

Hi,

I'm from Tracestrack Maps and I'd like to provide the Topo map as an imagery to help mappers.

@LaoshuBaby
Copy link

Wow, thank you for geneous grant your tiles' access to iD, but I guess iD's imagery index are build from editor-layer-index project?

iD/FAQ.md

Lines 17 to 19 in cc920d3

iD's list of available background imagery sources come from the [editor-layer-index](https://github.com/osmlab/editor-layer-index)
project. If you know of a more recent imagery source that is licensed for this use,
please open a request there with the link and license details.

https://github.com/osmlab/editor-layer-index/blob/9d718bed470f65b17d49b45c0e2f09093f013626/README.md?plain=1#L24

(I'm not the developer of iD so the above is just guessed)

@tordans
Copy link
Collaborator

tordans commented Mar 4, 2024

iD's imagery index are build from editor-layer-index project

That is true. That will also be the place where licensing will be verified.

@quinncnl
Copy link
Author

quinncnl commented Mar 4, 2024

Thank you both. A quick question before I go there, will the API key be shared across all projects? I only want the key to be used in iD to start with.

@bryceco
Copy link
Contributor

bryceco commented Mar 4, 2024

It will be shared across projects, but there are only a few projects other than iD that use ELI. JOSM uses its own layer index.

You can also add it without specifying an api key, and issue keys separately to client projects (but there's no guarantee they will special-case your layer to support the key).

@tyrasd
Copy link
Member

tyrasd commented Mar 4, 2024

I only want the key to be used in iD to start with.

As already pointed out above, this is not quite the preferred way by the community. But if you would like to continue that approach, you would add the layer using an {apikey} placeholder to ELI, and simultaneously add the layer also to iD in data/manual_imagery.json, where the api key can also be stored in an obfuscated way such that it is not picked up by search engines and/or "malicious" scrapers.

as an imagery to help mappers

Again, thank you for this kind offer. For mapping, I'm seeing the layer's biggest benefit in the very high quality contour lines. That could be quite useful. On the other hand, there's little benefit in having rendered OSM data in the background map while mapping, and it could potentially be even distracting. Just out of curiosity: Would there be the possibility of you creating a dedicated rendering based on this map, but which excludes the OSM data? That would be more useful for mapping, specifically.

@quinncnl
Copy link
Author

quinncnl commented Mar 6, 2024

Again, thank you for this kind offer. For mapping, I'm seeing the layer's biggest benefit in the very high quality contour lines. That could be quite useful. On the other hand, there's little benefit in having rendered OSM data in the background map while mapping, and it could potentially be even distracting. Just out of curiosity: Would there be the possibility of you creating a dedicated rendering based on this map, but which excludes the OSM data? That would be more useful for mapping, specifically.

Indeed the most useful part for mappers is LiDAR based contour lines for Europe. We don't have dedicated contour lines at the moment. But that's definitely something worth looking into.

@quinncnl quinncnl closed this Mar 6, 2024
@quinncnl
Copy link
Author

For the record I opened a PR to ELI: osmlab/editor-layer-index#2264 For JOSM it's already been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants